Skip to content

Migrate to Svelte 4 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Niek opened this issue Jun 22, 2023 · 5 comments
Open

Migrate to Svelte 4 #199

Niek opened this issue Jun 22, 2023 · 5 comments

Comments

@Niek
Copy link
Owner

Niek commented Jun 22, 2023

See: https://svelte.dev/blog/svelte-4

It might be as simple as npx svelte-migrate svelte-4. We need to check if all dependencies work properly.

@Webifi
Copy link
Contributor

Webifi commented Jun 22, 2023

Gave it a shot, but some dependency issues:
(svelte-markdown doesn't look too active, but someone will probably update or fork it, not sure about some of the others)

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/svelte
npm WARN   dev svelte@"^4.0.0" from the root project
npm WARN   9 more (@sveltejs/vite-plugin-svelte, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer svelte@"^3.2.0" from [email protected]     
npm WARN node_modules/eslint-plugin-svelte3
npm WARN   dev eslint-plugin-svelte3@"^4.0.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/svelte
npm WARN   dev svelte@"^4.0.0" from the root project
npm WARN   9 more (@sveltejs/vite-plugin-svelte, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer svelte@"^3.0.0" from [email protected]
npm WARN node_modules/svelte-markdown
npm WARN   dev svelte-markdown@"^0.2.3" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/svelte
npm WARN   dev svelte@"^4.0.0" from the root project
npm WARN   9 more (@sveltejs/vite-plugin-svelte, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer svelte@"^3.0.0" from [email protected]
npm WARN node_modules/svelte-modals
npm WARN   dev svelte-modals@"^1.2.1" from the root project

@Niek
Copy link
Owner Author

Niek commented Jun 27, 2023

Checked into this:

@Webifi
Copy link
Contributor

Webifi commented Jun 27, 2023

Migrating to eslint-plugin-svelte looks like it will take a little bit of work:
sveltejs/eslint-plugin-svelte3#184

For svelte-markdown, maybe just maintain your own fork. Looks like the change is easy:
pablo-abc/svelte-markdown@main...machellerogden:svelte-markdown:main

@Niek
Copy link
Owner Author

Niek commented Jul 10, 2023

This would be an good workaround for svelte-markdown:
pablo-abc/svelte-markdown#72 (comment)

@Niek
Copy link
Owner Author

Niek commented Jan 26, 2024

I made a Svelte 4 branch now: https://github.com/Niek/chatgpt-web/tree/svelte-4

Everything compiles fine, there's just 650+ linting issues to resolve left 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants