From 8baacd33d1af111ed3669352d7617b5cdc8c54e6 Mon Sep 17 00:00:00 2001
From: "John Paul E. Balandan, CPA" <paulbalandan@gmail.com>
Date: Wed, 8 Jan 2025 01:42:00 +0800
Subject: [PATCH] Less ignoring of errors for PHP 8.4

---
 .github/workflows/static-code-analysis.yml | 5 ++++-
 .github/workflows/unit-tests.yml           | 3 +--
 phpstan.dist.neon                          | 4 +++-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/static-code-analysis.yml b/.github/workflows/static-code-analysis.yml
index 20e18fd..94f161f 100644
--- a/.github/workflows/static-code-analysis.yml
+++ b/.github/workflows/static-code-analysis.yml
@@ -26,7 +26,8 @@ jobs:
       fail-fast: false
       matrix:
         php-version:
-          - 8.3
+          - '8.3'
+          - '8.4'
 
     name: Static Code Analysis
     runs-on: ubuntu-24.04
@@ -102,6 +103,8 @@ jobs:
 
       - name: Check - PHP-CS-Fixer
         run: composer cs:check
+        env:
+          PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.php-version == '8.4' && '1' || ''}}
 
       - name: Check - PHPStan
         run: composer phpstan:check
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 10f5fae..16a98c1 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -59,7 +59,6 @@ jobs:
         shell: bash
         run: |
           echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_OUTPUT
-          echo "EXPERIMENTAL_FLAG=${{ matrix.php-version == '8.4' && '--ignore-platform-req=php' || '' }}" >> $GITHUB_OUTPUT
 
       - name: Cache Composer dependencies
         uses: actions/cache@v4
@@ -71,7 +70,7 @@ jobs:
             ${{ github.workflow }}-PHP_${{ matrix.php-version }}-
 
       - name: Install dependencies
-        run: composer update --ansi ${{ steps.globals.outputs.EXPERIMENTAL_FLAG }}
+        run: composer update --ansi
 
       - name: Run Unit Tests
         shell: bash
diff --git a/phpstan.dist.neon b/phpstan.dist.neon
index 655cd42..8fbde8b 100644
--- a/phpstan.dist.neon
+++ b/phpstan.dist.neon
@@ -4,7 +4,9 @@ includes:
   - src/Nexus/PHPStan/extension.neon
 
 parameters:
-  phpVersion: 80300
+  phpVersion:
+    min: 80300
+    max: 80499
   level: 10
   tmpDir: build/phpstan
   paths: