Merge pull request #2877 from erri120/fix/2463

Fix suggested folder name in Advanced Installer

Author: erri120

src/Games/NexusMods.Games.AdvancedInstaller.UI/Content/Right/SelectLocation/SelectLocationViewModel.cs

@@ -64,21 +64,23 @@ private static IEnumerable<ISuggestedEntryViewModel> CreateSuggestedEntries(IGam
         foreach (var (locationId, fullPath) in register.GetTopLevelLocations())
         {
             suggestedEntries.Add(new SuggestedEntryViewModel(
-                Guid.NewGuid(),
-                fullPath,
-                locationId,
-                new GamePath(locationId, RelativePath.Empty)));
+                id: Guid.NewGuid(),
+                absolutePath: fullPath,
+                associatedLocation: locationId,
+                relativeToTopLevelLocation: new GamePath(locationId, RelativePath.Empty)
+            ));
 
             // Add nested locations to suggested entries.
             foreach (var nestedLocation in register.GetNestedLocations(locationId))
             {
                 var nestedFullPath = register.GetResolvedPath(nestedLocation);
                 var relativePath = nestedFullPath.RelativeTo(fullPath);
                 suggestedEntries.Add(new SuggestedEntryViewModel(
-                    Guid.NewGuid(),
-                    nestedFullPath,
-                    nestedLocation,
-                    new GamePath(locationId, relativePath)));
+                    id: Guid.NewGuid(),
+                    absolutePath: nestedFullPath,
+                    associatedLocation: nestedLocation,
+                    relativeToTopLevelLocation: new GamePath(locationId, relativePath)
+                ));
             }
         }
 

src/Games/NexusMods.Games.AdvancedInstaller.UI/Content/Right/SelectLocation/SuggestedEntry/SuggestedEntryViewModel.cs

@@ -38,8 +38,8 @@ public SuggestedEntryViewModel(
         AssociatedLocation = associatedLocation;
         RelativeToTopLevelLocation = relativeToTopLevelLocation;
 
-        Title = title == string.Empty ? associatedLocation.Value.ToString() : title;
-        Subtitle = subtitle == string.Empty ? AbsolutePath.ToString() : subtitle;
+        Title = string.IsNullOrEmpty(title) ? associatedLocation.ToString() : title;
+        Subtitle = string.IsNullOrEmpty(subtitle) ? AbsolutePath.ToString() : subtitle;
 
         CreateMappingCommand = ReactiveCommand.Create(() => { });
     }