Merge pull request #2808 from Nexus-Mods/fix/outdated-dep-diagnostic

Select highest installed version for SDV dependency diagnostics

Author: Al12rs

src/Games/NexusMods.Games.StardewValley/Emitters/DependencyDiagnosticEmitter.cs

@@ -77,9 +77,10 @@ private static KeyValuePair<SMAPIModLoadoutItemId, SMAPIManifest> SelectUniqueId
         IGrouping<string, KeyValuePair<SMAPIModLoadoutItemId, SMAPIManifest>> g)
     {
         // TODO: select winner based on synchronizer winner
-        // For now prefer enabled mods over disabled ones
-        var enabledItem = g.FirstOrOptional(kv => LoadoutItem.Load(loadout.Db, kv.Key).IsEnabled());
-        return enabledItem.HasValue ? enabledItem.Value : g.First();
+        // For now prefer enabled mods over disabled ones, newer versions over older ones
+        var sortedItems = g.OrderByDescending(kv => kv.Value.Version).ToArray();
+        var enabledItem = sortedItems.FirstOrOptional(kv => LoadoutItem.Load(loadout.Db, kv.Key).IsEnabled());
+        return enabledItem.HasValue ? enabledItem.Value : sortedItems.First();
     }
 
     private static IEnumerable<Diagnostic> DiagnoseDisabledDependencies(