Merge pull request #2859 from erri120/feat/2682

Allow pages to specify serializable page data

Author: erri120

Diff for: src/NexusMods.App.UI/Pages/Diagnostics/Details/DiagnosticDetailsPage.cs

@@ -1,6 +1,7 @@
 using JetBrains.Annotations;
 using Microsoft.Extensions.DependencyInjection;
 using NexusMods.Abstractions.Diagnostics;
+using NexusMods.Abstractions.Loadouts;
 using NexusMods.App.UI.Controls.MarkdownRenderer;
 using NexusMods.App.UI.WorkspaceSystem;
 
@@ -10,8 +11,23 @@ public record DiagnosticDetailsPageContext : IPageFactoryContext
 {
     public required Diagnostic Diagnostic { get; init; }
 
+    public required LoadoutId LoadoutId { get; init; }
+
     /// <inheritdoc/>
     public bool IsEphemeral => true;
+
+    /// <inheritdoc/>
+    public PageData GetSerializablePageData()
+    {
+        return new PageData
+        {
+            FactoryId = DiagnosticListPageFactory.StaticId,
+            Context = new DiagnosticListPageContext
+            {
+                LoadoutId = LoadoutId,
+            },
+        };
+    }
 }
 
 [UsedImplicitly]

Diff for: src/NexusMods.App.UI/Pages/Diagnostics/List/DiagnosticListViewModel.cs

@@ -152,6 +152,7 @@ public DiagnosticListViewModel(
                                     Context = new DiagnosticDetailsPageContext
                                     {
                                         Diagnostic = diagnostic,
+                                        LoadoutId = LoadoutId,
                                     },
                                 };
 

Diff for: src/NexusMods.App.UI/WorkspaceSystem/Page/IPageFactoryContext.cs

@@ -11,6 +11,11 @@ public interface IPageFactoryContext
     /// </summary>
     bool IsEphemeral => false;
 
+    /// <summary>
+    /// Alternative <see cref="PageData"/> to persist when <see cref="IsEphemeral"/> is <c>true</c>.
+    /// </summary>
+    PageData? GetSerializablePageData() => null;
+
     /// <summary>
     /// Gets the tracking name.
     /// </summary>

Diff for: src/NexusMods.App.UI/WorkspaceSystem/PanelTab/PanelTabViewModel.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Reactive;
 using DynamicData.Kernel;
 using NexusMods.Abstractions.UI;
@@ -45,12 +46,20 @@ public PanelTabViewModel(IWorkspaceController workspaceController, WorkspaceId w
 
     public TabData? ToData()
     {
-        if (Contents.PageData.Context.IsEphemeral) return null;
+        var pageData = Contents.PageData;
+        if (pageData.Context.IsEphemeral)
+        {
+            var serializablePageData = pageData.Context.GetSerializablePageData();
+            if (serializablePageData is null) return null;
+
+            Debug.Assert(!serializablePageData.Context.IsEphemeral);
+            pageData = serializablePageData;
+        }
 
         return new TabData
         {
             Id = Id,
-            PageData = Contents.PageData,
+            PageData = pageData,
         };
     }
 }