Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeuralynxRawIO issue when folders are present #1637

Open
emelon8 opened this issue Jan 28, 2025 · 5 comments
Open

NeuralynxRawIO issue when folders are present #1637

emelon8 opened this issue Jan 28, 2025 · 5 comments
Labels

Comments

@emelon8
Copy link

emelon8 commented Jan 28, 2025

I recently updated to Neo v.0.13.4, and it's broken my ability to import Neuralynx files. On lines 226-228 of neuralynxrawio.py, it looks through the contents of the directory whose name I provided when the object is instantiated. But when it comes across the "ConfigurationLog" subdirectory that Neuralynx automatically generated, it throws an error (since it's a folder, not a file). Is there a way to avoid this issue?

@emelon8 emelon8 added the bug label Jan 28, 2025
@zm711
Copy link
Contributor

zm711 commented Jan 29, 2025

I think @samuelgarcia worked on this most recently? Any chance you get share a minimal representation of this folder structure so I could debug on my end? Maybe just a zip of the ConfigurationLog + one normal file. I can find an email to share if you only want to share the folder privately. But I'm sure this is just because the test files we were given were missing the subdir so we didn't realize that happened. Which version of neurallynx are you using and could you also test neo 0.14.0 since we just updated :)

@emelon8
Copy link
Author

emelon8 commented Jan 31, 2025

Here's a link to some data: https://byu.box.com/s/h67dx0lzrxy7yhff4eloly7yx4drqoks. I'm using v.0.13.4--I just installed v.0.14.0 and it has the same issue.

@samuelgarcia
Copy link
Contributor

Hi. Not sure I will have time very soon to fix this. But I put this on my todo list.
Maybe it is already solved in one of the many improvement done by @PeterNSteinmetz
#1568
#1566

@PeterNSteinmetz
Copy link
Contributor

@samuelgarcia I do not think this is addressed in either of those PRs. Looking at the code I think it does only properly account for files and subdirectories will be mis-interpreted. This can be fixed in a future PR though there is a fairly long queue of those to be addressed. A subdirectory should likely be added to one of the test data subdirectories as well.

For a temporary workaround, I can think of two things:

  1. Move any subdirectories out of the directory with the main files to be analyzed.
  2. Programmatically generate a list of the full absolute pathnames of files to be processed and provide it as the 'include_filenames' argument.

@emelon8
Copy link
Author

emelon8 commented Jan 31, 2025

@samuelgarcia @PeterNSteinmetz We'll keep moving the subdirectories out of the directory for the time being. Thank you both for responding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants