Update private deck to have ID as a card slot.

Author: plural

app/controllers/decks_controller.rb

@@ -17,6 +17,8 @@ def show
   end
 
   def create
+    # TODO(plural): Wrap all of this in a transaction.
+
     # Use the incoming parameters, but build the actual object against the model directly.
 
     new_deck = Deck.new
@@ -33,8 +35,9 @@ def create
     # TODO(plural): Flesh out nice error messages.
     raise ApplicationController::BadDeckError, 'There was an error creating your deck.' unless new_deck.save
 
+    new_deck.deck_cards.create(card_id: new_deck.identity_card_id, quantity: 1)
     card_slots.each do |card_id, quantity|
-      new_deck.card_slots.create(card_id:, quantity:)
+      new_deck.deck_cards.create(card_id:, quantity:)
     end
 
     simplified_params = { data: { id: new_deck.id, type: 'decks' } }

app/models/deck.rb

@@ -21,4 +21,16 @@ class Deck < ApplicationRecord
 
   has_many :deck_cards
   has_many :cards, through: :deck_cards
+
+  def card_slots
+    deck_cards.order(:card_id).each_with_object({}) { |c, h| h[c.card_id] = c.quantity }
+  end
+
+  def num_cards
+    deck_cards
+      # Exclude identity
+      .reject { |c| c.card_id == identity_card_id }
+      .map(&:quantity).sum
+  end
+
 end

app/models/deck_card.rb

@@ -6,7 +6,7 @@ class DeckCard < ApplicationRecord
 
   belongs_to :deck,
              primary_key: :id,
-             inverse_of: :card_slots,
+             inverse_of: :deck_cards,
              touch: true
   belongs_to :card,
              primary_key: :id

app/resources/deck_resource.rb

@@ -26,17 +26,8 @@ class DeckResource < PrivateApplicationResource
     end
   end
 
-  attribute :card_slots, :hash do
-    cards = {}
-    @object.deck_cards.order(:card_id).each do |c|
-      cards[c.card_id] = c.quantity
-    end
-    cards
-  end
-
-  attribute :num_cards, :integer do
-    @object.deck_cards.map(&:quantity).sum
-  end
+  attribute :card_slots, :hash
+  attribute :num_cards, :integer
 
   # This is the basic definition, but does not take restriction modifications
   # into account. Leaving this here as an example for now, but it will need to
@@ -66,13 +57,5 @@ class DeckResource < PrivateApplicationResource
     end
   end
 
-  # The rubocop warning is disabled because this relationship won't work
-  # without it because there is no identity_card table.
-  belongs_to :identity_card, resource: CardResource, foreign_key: :identity_card_id do # rubocop:disable Rails/RedundantForeignKey
-    link do |deck|
-      format('%<url>s/%<id>s', url: Rails.application.routes.url_helpers.cards_url, id: deck.identity_card_id)
-    end
-  end
-
   many_to_many :cards
 end