Merge pull request #308 from plural/enable-rubocop-on-github

Enable rubocop lint checks on Github.

Author: plural

.github/workflows/ci.yml

@@ -84,9 +84,8 @@ jobs:
         run: bundle exec bundler-audit --update
       - name: Security audit application code
         run: bundle exec brakeman -q -w2
-      # TODO(plural): Uncomment when lint errors are clean and we want to block on them.
-      # - name: Lint Ruby files
-      #   run: bin/rubocop --parallel
+      - name: Lint Ruby files
+        run: bundle exec rubocop --parallel
 
   build_and_push:
     name: Build docker image

.rubocop.yml

@@ -14,6 +14,8 @@ Metrics/MethodLength:
   Max: 100
 Metrics/PerceivedComplexity:
   Enabled: false
+Rails/BulkChangeTable:
+  Enabled: false
 Rails/HasManyOrHasOneDependent:
   Enabled: false
 RSpec/ExampleLength:

db/migrate/20220917233220_add_detailed_attributes_to_cards.rb

@@ -2,7 +2,7 @@
 
 class AddDetailedAttributesToCards < ActiveRecord::Migration[7.0] # rubocop:disable Style/Documentation
   def change
-    add_column :cards, :additional_cost, :bool, default: false # rubocop:disable Rails/BulkChangeTable
+    add_column :cards, :additional_cost, :bool, default: false
     add_column :cards, :advanceable, :bool, default: false
     add_column :cards, :gains_subroutines, :bool, default: false
     add_column :cards, :interrupt, :bool, default: false

db/migrate/20240512213120_add_pronunciation_to_cards.rb

@@ -2,7 +2,7 @@
 
 class AddPronunciationToCards < ActiveRecord::Migration[7.1] # rubocop:disable Style/Documentation
   def change
-    add_column :cards, :pronunciation_approximation, :string # rubocop:disable Rails/BulkChangeTable
+    add_column :cards, :pronunciation_approximation, :string
     add_column :cards, :pronunciation_ipa, :string
   end
 end