Merge pull request #411 from lahlidahlia/main

Check that the card is NSG before serving xlarge images

Author: lahlidahlia

app/models/printing.rb

@@ -43,6 +43,18 @@ def latest_printing_id
     nil
   end
 
+  def xlarge_image?
+    # The excluded sets were designed by FFG despite being released by NSG. We do not want to distribute high quality
+    # versions of them.
+    released_by == 'null_signal_games' &&
+      !%w[
+        system_core_2019
+        magnum_opus_reprint
+        salvaged_memories
+        system_update_2021
+      ].include?(card_set_id)
+  end
+
   def restrictions
     {
       banned: restrictions_banned,

app/resources/card_resource.rb

@@ -74,7 +74,10 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
 
     unless @object.num_extra_faces.zero?
       @object.face_indices.each do |index|
-        f = { index:, images: images(@object.latest_printing_id, face_index: index) }
+        f = { index:,
+              images: images(@object.latest_printing_id,
+                             @object.printings.order(:date_release).reverse_order.first.xlarge_image?,
+                             face_index: index) }
         f[:base_link] = @object.faces_base_link[index] if @object.faces_base_link[index]
         f[:display_subtypes] = @object.faces_display_subtypes[index] if @object.faces_display_subtypes[index]
         f[:card_subtype_ids] = @object.faces_card_subtype_ids[index].compact if @object.faces_card_subtype_ids[index]
@@ -93,7 +96,8 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
   attribute :restrictions, :hash
   attribute :latest_printing_id, :string
   attribute :latest_printing_images, :hash do
-    images(@object.latest_printing_id, has_narrative_image: @object.narrative_text.present?)
+    images(@object.latest_printing_id, @object.printings.order(:date_release).reverse_order.first.xlarge_image?,
+           has_narrative_image: @object.narrative_text.present?)
   end
 
   filter :card_cycle_id, :string do
@@ -163,16 +167,16 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
 
   private
 
-  def images(id, has_narrative_image: false, face_index: nil)
+  def images(id, has_xlarge_image, has_narrative_image: false, face_index: nil)
     url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
     face_suffix = "-#{face_index}" unless face_index.nil?
     image_sizes = {
       'tiny' => "#{url_prefix}/tiny/#{id}#{face_suffix}.jpg",
       'small' => "#{url_prefix}/small/#{id}#{face_suffix}.jpg",
       'medium' => "#{url_prefix}/medium/#{id}#{face_suffix}.jpg",
-      'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg",
-      'xlarge' => "#{url_prefix}/xlarge/#{id}#{face_suffix}.webp"
+      'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg"
     }
+    image_sizes[:xlarge] = "#{url_prefix}/xlarge/#{id}#{face_suffix}.webp" if has_xlarge_image
 
     image_sizes['narrative'] = "#{url_prefix}/xlarge/#{id}#{face_suffix}-narrative.webp" if has_narrative_image
 

app/resources/printing_resource.rb

@@ -85,7 +85,7 @@ class PrintingResource < ApplicationResource # rubocop:disable Metrics/ClassLeng
   attribute :pronunciation_ipa, :string
 
   attribute :images, :hash do
-    images(@object.id, has_narrative_image: @object.narrative_text.present?)
+    images(@object.id, @object.xlarge_image?, has_narrative_image: @object.narrative_text.present?)
   end
   attribute :card_abilities, :hash
   attribute :latest_printing_id, :string
@@ -99,7 +99,7 @@ class PrintingResource < ApplicationResource # rubocop:disable Metrics/ClassLeng
 
     unless @object.num_extra_faces.zero?
       @object.face_indices.each do |index|
-        f = { index:, images: images(@object.id, face_index: index) }
+        f = { index:, images: images(@object.id, @object.xlarge_image?, face_index: index) }
         f[:base_link] = @object.faces_base_link[index] if @object.faces_base_link[index]
         f[:copy_quantity] = @object.faces_copy_quantity[index] if @object.faces_copy_quantity[index]
         f[:flavor] = @object.faces_flavor[index] if @object.faces_flavor[index]
@@ -179,16 +179,16 @@ class PrintingResource < ApplicationResource # rubocop:disable Metrics/ClassLeng
 
   private
 
-  def images(id, has_narrative_image: false, face_index: nil)
+  def images(id, has_xlarge_image, has_narrative_image: false, face_index: nil)
     url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
     face_suffix = "-#{face_index}" unless face_index.nil?
     image_sizes = {
       'tiny' => "#{url_prefix}/tiny/#{id}#{face_suffix}.jpg",
       'small' => "#{url_prefix}/small/#{id}#{face_suffix}.jpg",
       'medium' => "#{url_prefix}/medium/#{id}#{face_suffix}.jpg",
-      'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg",
-      'xlarge' => "#{url_prefix}/xlarge/#{id}#{face_suffix}.webp"
+      'large' => "#{url_prefix}/large/#{id}#{face_suffix}.jpg"
     }
+    image_sizes[:xlarge] = "#{url_prefix}/xlarge/#{id}#{face_suffix}.webp" if has_xlarge_image
 
     image_sizes['narrative'] = "#{url_prefix}/xlarge/#{id}#{face_suffix}-narrative.webp" if has_narrative_image
 

spec/resources/card_resource_reads_spec.rb

@@ -72,6 +72,31 @@
     end
   end
 
+  describe 'has xlarge image' do
+    let!(:card) { Card.find('hoshiko_shiro_untold_protagonist') }
+
+    it 'has xlarge image' do
+      params[:filter] = { id: { eq: card.id } }
+      render
+
+      data = jsonapi_data[0]
+      expect(data.latest_printing_images[:nrdb_classic][:xlarge]).to eq("https://card-images.netrunnerdb.com/v2/xlarge/#{card.latest_printing_id}.webp")
+      expect(data.faces[0][:images][:nrdb_classic][:xlarge]).to eq("https://card-images.netrunnerdb.com/v2/xlarge/#{card.latest_printing_id}-0.webp")
+    end
+  end
+
+  describe 'no xlarge image' do
+    let!(:card) { Card.find('adonis_campaign') }
+
+    it 'no xlarge image' do
+      params[:filter] = { id: { eq: card.id } }
+      render
+
+      data = jsonapi_data[0]
+      expect(data.latest_printing_images[:nrdb_classic][:xlarge]).to be_falsy
+    end
+  end
+
   describe 'filtering' do
     let!(:card) { Card.find('pennyshaver') }
 

spec/resources/printing_resource_reads_spec.rb

@@ -87,6 +87,31 @@
     end
   end
 
+  describe 'has xlarge image' do
+    let!(:printing) { Printing.find('01072') }  # Hoshiko
+
+    it 'has xlarge image' do
+      params[:filter] = { id: { eq: printing.id } }
+      render
+
+      data = jsonapi_data[0]
+      expect(data.images[:nrdb_classic][:xlarge]).to eq("https://card-images.netrunnerdb.com/v2/xlarge/#{printing.id}.webp")
+      expect(data.faces[0][:images][:nrdb_classic][:xlarge]).to eq("https://card-images.netrunnerdb.com/v2/xlarge/#{printing.id}-0.webp")
+    end
+  end
+
+  describe 'no xlarge image' do
+    let!(:printing) { Printing.find('01056') }  # Adonis Campaign
+
+    it 'no xlarge image' do
+      params[:filter] = { id: { eq: printing.id } }
+      render
+
+      data = jsonapi_data[0]
+      expect(data.images[:nrdb_classic][:xlarge]).to be_falsy
+    end
+  end
+
   describe 'filtering' do
     let!(:printing) { Printing.find('21180') }