Merge pull request #293 from plural/spec-and-test-lint

Fix lint issues for test/ and spec/ dirs.

Author: plural

.rubocop.yml

@@ -14,3 +14,11 @@ Metrics/PerceivedComplexity:
   Enabled: false
 Rails/HasManyOrHasOneDependent:
   Enabled: false
+RSpec/ExampleLength:
+  Enabled: false
+RSpec/ExampleWording:
+  Enabled: false
+RSpec/FilePath:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false

spec/acceptance/card_cycles_spec.rb

@@ -7,15 +7,15 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Cycle resources have the following relationships for their records.
 
     * Card Sets
     * Cards
     * Printings
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_cycles' do
     example_request 'All Card Cycles' do

spec/acceptance/card_pools_spec.rb

@@ -7,7 +7,7 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Pool resources have the following relationships for their records.
@@ -16,7 +16,7 @@
     * Card Sets
     * Format
     * Snapshots
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_pools' do
     example_request 'All Card Pools' do

spec/acceptance/card_set_types_spec.rb

@@ -7,13 +7,13 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Set Type resources have the following relationships for their records.
 
     * Card Sets
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_set_types' do
     example_request 'All Card Set Types' do

spec/acceptance/card_sets_spec.rb

@@ -7,7 +7,7 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Set resources have the following relationships for their records.
@@ -16,7 +16,7 @@
     * Card Set Type
     * Cards
     * Printings
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_sets' do
     example_request 'All Card Sets' do

spec/acceptance/card_subtype_spec.rb

@@ -7,14 +7,14 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Subtype resources have the following relationships for their records.
 
     * Cards
     * Printings
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_subtypes' do
     example_request 'All Card Subtypes' do

spec/acceptance/card_type_spec.rb

@@ -7,15 +7,15 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card Type resources have the following relationships for their records.
 
     * Cards
     * Printings
     * Side
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/card_types' do
     example_request 'All Card Types' do

spec/acceptance/cards_spec.rb

@@ -7,7 +7,7 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Card resources have the following relationships for their records.
@@ -21,7 +21,7 @@
     * Printings
     * Rulings
     * Side
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/cards' do
     example_request 'All Cards' do
@@ -43,12 +43,15 @@
 
     # TODO(plural): Enforce sort order by type and primary field name.
     fields = CardSearchQueryBuilder.fields.map do |x|
-      format('* **%s**: Type: %s%s', x.keywords.join(', '), x.type.to_s,
-             x.documentation.nil? ? '' : "\n  * %s" % x.documentation)
+      format('* **%<keywords>s**: Type: %<type>s%<documentation>s',
+             keywords: x.keywords.join(', '),
+             type: x.type.to_s,
+             documentation: x.documentation.nil? ? '' : "\n  * #{x.documentation}")
     end
     let(:query) { 'gamble' }
     example_request 'Filter - Card Search Operator' do
-      explanation format("%s\n### Fields and their types\n%s", SearchQueryBuilder.search_filter_docs, fields.join("\n"))
+      explanation format("%<docs>s\n### Fields and their types\n%<fields>s",
+                         docs: SearchQueryBuilder.search_filter_docs, fields: fields.join("\n"))
 
       expect(status).to eq 200
     end

spec/acceptance/decklists_spec.rb

@@ -7,7 +7,7 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     Decklists are published decks from users.
 
     ## Relationships
@@ -19,7 +19,7 @@
     * Identity Card
     * Cards
 
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/decklists' do
     example_request 'All Decklists' do
@@ -40,12 +40,12 @@
     parameter :card_id, type: :string, required: true
 
     example_request 'Filter - Get decklists containing all supplied Card ids' do
-      explanation <<~EOM
+      explanation <<~EXPLANATION
         The card_id filter can accept a single card_id or a comma-separated list of card ids.
 
         If multiple card ids are supplied, the decklist must contain all of the
         cards to be included in the results.
-      EOM
+      EXPLANATION
 
       expect(status).to eq 200
     end

spec/acceptance/factions_spec.rb

@@ -7,7 +7,7 @@
   header 'Content-Type', 'application/json'
   header 'Host', 'api-preview.netrunnerdb.com'
 
-  explanation <<~HEREDOC
+  explanation <<~EXPLANATION
     ## Relationships
 
     Faction resources have the following relationships for their records.
@@ -16,7 +16,7 @@
     * Decklists
     * Printings
     * Side
-  HEREDOC
+  EXPLANATION
 
   get '/api/v3/public/factions' do
     example_request 'All Factions' do