Skip to content

Commit 200aefd

Browse files
authored
Merge pull request #318 from plural/sort-printings-cycles-and-sets
Sort {card_cycle,card_set,printing}_{ids,names} fields for cards + printings
2 parents 736bc2c + 2fce46c commit 200aefd

20 files changed

+831
-167
lines changed

app/resources/card_resource.rb

+11-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
2828
attribute :memory_cost, :integer
2929
attribute :minimum_deck_size, :integer
3030
attribute :num_printings, :integer
31-
attribute :printing_ids, :array_of_strings
31+
attribute :printing_ids, :array_of_strings do
32+
@object.printing_ids_in_database
33+
end
3234
attribute :date_release, :date
3335
attribute :restriction_ids, :array_of_strings
3436
attribute :strength, :integer
@@ -43,8 +45,14 @@ class CardResource < ApplicationResource # rubocop:disable Metrics/ClassLength
4345
attribute :format_ids, :array_of_strings
4446
attribute :card_pool_ids, :array_of_strings
4547
attribute :snapshot_ids, :array_of_strings
46-
attribute :card_cycle_ids, :array_of_strings
47-
attribute :card_set_ids, :array_of_strings
48+
attribute :card_cycle_ids, :array_of_strings do
49+
@object.card_cycle_ids_in_database
50+
end
51+
attribute :card_cycle_names, :array_of_strings
52+
attribute :card_set_ids, :array_of_strings do
53+
@object.card_set_ids_in_database
54+
end
55+
attribute :card_set_names, :array_of_strings
4856
attribute :designed_by, :string
4957
attribute :printings_released_by, :array_of_strings
5058
attribute :pronouns, :string

app/resources/printing_resource.rb

+8-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,14 @@ class PrintingResource < ApplicationResource # rubocop:disable Metrics/ClassLeng
6060
attribute :format_ids, :array_of_strings
6161
attribute :card_pool_ids, :array_of_strings
6262
attribute :snapshot_ids, :array_of_strings
63-
attribute :card_cycle_ids, :array_of_strings
64-
attribute :card_set_ids, :array_of_strings
63+
attribute :card_cycle_ids, :array_of_strings do
64+
@object.card_cycle_ids_in_database
65+
end
66+
attribute :card_cycle_names, :array_of_strings
67+
attribute :card_set_ids, :array_of_strings do
68+
@object.card_set_ids_in_database
69+
end
70+
attribute :card_set_names, :array_of_strings
6571
attribute :designed_by, :string
6672
attribute :released_by, :string
6773
attribute :printings_released_by, :array_of_strings
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# frozen_string_literal: true
2+
3+
class UpdateUnifiedPrintingsToVersion9 < ActiveRecord::Migration[7.1] # rubocop:disable Style/Documentation
4+
def change
5+
update_view :unified_printings,
6+
version: 9,
7+
revert_to_version: 8,
8+
materialized: true
9+
end
10+
end
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# frozen_string_literal: true
2+
3+
class UpdateUnifiedCardsToVersion7 < ActiveRecord::Migration[7.1] # rubocop:disable Style/Documentation
4+
def change
5+
update_view :unified_cards,
6+
version: 7,
7+
revert_to_version: 6,
8+
materialized: true
9+
end
10+
end

db/schema.rb

+149-149
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)