Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup for Thread shield IP UI: manage blocked IPs #925

Closed
gsanchietti opened this issue Nov 20, 2024 · 7 comments
Closed

Mockup for Thread shield IP UI: manage blocked IPs #925

gsanchietti opened this issue Nov 20, 2024 · 7 comments
Assignees

Comments

@gsanchietti
Copy link
Member

gsanchietti commented Nov 20, 2024

Create a mockup for parent issue: #924

The mockup should address the following tasks:

  1. Dynamic Blocklist Management:

    • Create a section to display all IP addresses currently on the dynamic blocklist.
    • Implement a search bar to search for a specific IP address within the dynamic blocklist.
    • Provide an option to unban an IP address directly from the UI.
  2. All Blocklists Management:

    • Add a search functionality in the UI to look up a specific IP address across all blocklists (both dynamic and static).
@gsanchietti gsanchietti added this to the NethSecurity 8.5 milestone Nov 20, 2024
@github-project-automation github-project-automation bot moved this to ToDo 🕐 in NethSecurity Nov 20, 2024
@gsanchietti gsanchietti changed the title Mockup for Thread shield UI Mockup for Thread shield IP UI: manage blocked IPs Jan 7, 2025
@AmaLuci AmaLuci moved this from ToDo 🕐 to In Progress 🛠 in NethSecurity Apr 2, 2025
@AmaLuci
Copy link

AmaLuci commented Apr 3, 2025

Mockups in Figma here

@AmaLuci AmaLuci moved this from In Progress 🛠 to Testing in NethSecurity Apr 3, 2025
@AmaLuci AmaLuci moved this from Testing to In Progress 🛠 in NethSecurity Apr 9, 2025
@AmaLuci AmaLuci self-assigned this Apr 9, 2025
@andre8244
Copy link
Collaborator

LGTM ✅

@andre8244 andre8244 removed their assignment Apr 10, 2025
@gsanchietti
Copy link
Member Author

Ok for me

@AmaLuci AmaLuci moved this from In Progress 🛠 to Testing in NethSecurity Apr 10, 2025
@AmaLuci AmaLuci assigned andre8244 and unassigned AmaLuci Apr 10, 2025
@AmaLuci
Copy link

AmaLuci commented Apr 10, 2025

Updated the mockups with the following changes:

  • Renamed section label from "Dynamic blocklist" to "Blocked IPs"
  • Added a "Ban expiration" column to the Blocked IPs table
  • Included the IP address in the unbanned toast message
  • Updated the empty state text
  • Replaced the toast with a confirmation tooltip and disabled button for the "Add to local allowlist" action
  • Added mouse hover effect on table rows for better interactivity

You can check the updated designs here: Figma link
@cotosso @Tbaile

@Tbaile
Copy link
Collaborator

Tbaile commented Apr 10, 2025

GJ! Just few things:

  • added a comment where, unfortunately, when searching if IP is inside an active list only the first hit is returned, not a list.
  • Is it possible to have a empty state for banned IPs? We have just the empty search state

@AmaLuci
Copy link

AmaLuci commented Apr 10, 2025

Empty state added and documented in NDS

@AmaLuci
Copy link

AmaLuci commented Apr 10, 2025

Edit: Added "Ban start" column

@AmaLuci AmaLuci closed this as completed Apr 10, 2025
@github-project-automation github-project-automation bot moved this from Testing to Done ✅ in NethSecurity Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

No branches or pull requests

5 participants