Skip to content

Commit a3aa292

Browse files
committed
fix tests
1 parent f26ef2c commit a3aa292

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

spectator-reg-atlas/src/test/java/com/netflix/spectator/atlas/impl/EvaluatorTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ public void sumAndMaxForGroup() {
117117
EvalPayload payload = evaluator.eval(0L, data("foo", 1.0, 2.0, 3.0));
118118

119119
List<EvalPayload.Metric> metrics = new ArrayList<>();
120-
metrics.add(new EvalPayload.Metric("max", Collections.emptyMap(), 3.0));
121-
metrics.add(new EvalPayload.Metric("sum", Collections.emptyMap(), 6.0));
120+
metrics.add(new EvalPayload.Metric("max", tags("name", "unknown"), 3.0));
121+
metrics.add(new EvalPayload.Metric("sum", tags("name", "unknown"), 6.0));
122122
EvalPayload expected = new EvalPayload(0L, metrics);
123123
Assertions.assertEquals(expected, sort(payload));
124124
}
@@ -133,7 +133,7 @@ public void updateSub() {
133133
evaluator.sync(sumSub);
134134
EvalPayload payload = evaluator.eval(0L, data("foo", 1.0, 2.0, 3.0));
135135
List<EvalPayload.Metric> metrics = new ArrayList<>();
136-
metrics.add(new EvalPayload.Metric("sum", Collections.emptyMap(), 6.0));
136+
metrics.add(new EvalPayload.Metric("sum", tags("name", "unknown"), 6.0));
137137
EvalPayload expected = new EvalPayload(0L, metrics);
138138
Assertions.assertEquals(expected, payload);
139139

@@ -143,7 +143,7 @@ public void updateSub() {
143143
evaluator.sync(maxSub);
144144
payload = evaluator.eval(0L, data("foo", 1.0, 2.0, 3.0));
145145
metrics = new ArrayList<>();
146-
metrics.add(new EvalPayload.Metric("sum", Collections.emptyMap(), 3.0));
146+
metrics.add(new EvalPayload.Metric("sum", tags("name", "unknown"), 3.0));
147147
expected = new EvalPayload(0L, metrics);
148148
Assertions.assertEquals(expected, payload);
149149
}
@@ -212,7 +212,7 @@ public void delayAggrCounterSum() {
212212

213213
Assertions.assertEquals(1, payload.getMetrics().size());
214214
Assertions.assertEquals(
215-
new EvalPayload.Metric("sum", tags(), 6.0),
215+
new EvalPayload.Metric("sum", tags("name", "unknown"), 6.0),
216216
payload.getMetrics().get(0)
217217
);
218218
}
@@ -229,7 +229,7 @@ public void delayAggrGaugeSum() {
229229
Assertions.assertEquals(3, payload.getMetrics().size());
230230
for (EvalPayload.Metric m : payload.getMetrics()) {
231231
Map<String, String> tags = m.getTags();
232-
Assertions.assertEquals(1, tags.size());
232+
Assertions.assertEquals(2, tags.size());
233233
Assertions.assertTrue(tags.containsKey("atlas.aggr"));
234234
}
235235
}
@@ -247,7 +247,7 @@ public void delayAggrGaugeCount() {
247247
Assertions.assertEquals(3, payload.getMetrics().size());
248248
for (EvalPayload.Metric m : payload.getMetrics()) {
249249
Map<String, String> tags = m.getTags();
250-
Assertions.assertEquals(1, tags.size());
250+
Assertions.assertEquals(2, tags.size());
251251
Assertions.assertTrue(tags.containsKey("atlas.aggr"));
252252
Assertions.assertEquals(1.0, m.getValue());
253253
}
@@ -294,7 +294,7 @@ public void delayAggrGaugeMax() {
294294

295295
Assertions.assertEquals(1, payload.getMetrics().size());
296296
Assertions.assertEquals(
297-
new EvalPayload.Metric("max", tags(), 3.0),
297+
new EvalPayload.Metric("max", tags("name", "unknown"), 3.0),
298298
payload.getMetrics().get(0)
299299
);
300300
}

0 commit comments

Comments
 (0)