Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x sync-init doesn't work with PollingDynamicConfig #371

Open
brharrington opened this issue Dec 10, 2015 · 0 comments
Open

2.x sync-init doesn't work with PollingDynamicConfig #371

brharrington opened this issue Dec 10, 2015 · 0 comments
Labels

Comments

@brharrington
Copy link
Contributor

When using FixedPollingStrategy it will keep retrying if the syncInit is true and the callback throws an exception. However, PollingDynamicConfig creates a runnable:

    52          strategy.execute(new Runnable() {
    53              @Override
    54              public void run() {
    55                  update();
    56              }
    57          });

That update call catches Exception and doesn't propagate:

    79              try {
    80                  PollingResponse response = reader.call();
    81                  if (response.hasData()) {
    82                      current = response.getToAdd();
    83                      notifyConfigUpdated(this);
    84                  }
    85              }
    86              catch (Exception e) {
    87                  errorCounter.incrementAndGet();
    88                  try {
    89                      notifyError(e, this);
    90                  }
    91                  catch (Exception e2) {
    92                      LOG.warn("Failed to notify error observer", e2);
    93                  }
    94              }
@elandau elandau added the v2 label May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants