Skip to content

fix: adapt tests for performance optimization for changelog build type #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: adapt tests for performance optimization for changelog build type #61

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f80ca7f
fix: changes to servers are no longer reported when comparing prefix …
b41ex Oct 5, 2025
f6189c2
fix: update expected result for prefix groups test
b41ex Oct 11, 2025
7488fd1
chore: clarify comments
b41ex Oct 12, 2025
a0db4b9
test: add step to check that operation view is opened for added opera…
b41ex Oct 13, 2025
6cf99b0
test: fix condition to wait for changed operations list shown
b41ex Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions src/tests/portal/12-grouping/12.1.5-pkg-prefix-grouping-viewing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,17 +154,17 @@ test.describe('12.1.4 Prefix grouping: Viewing', () => {
})
await compareSelectDialog.compareBtn.click()

/*! await expect(comparePage.toolbar.breakingChangesFilterBtn).toHaveText('2') //Issue TestCase-B-1442
await expect(comparePage.toolbar.breakingChangesFilterBtn).toHaveText('2') //Issue TestCase-B-1442
await expect(comparePage.toolbar.riskyChangesFilterBtn).toHaveText('0')
await expect(comparePage.toolbar.deprecatedChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.nonBreakingChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.nonBreakingChangesFilterBtn).toHaveText('4')
await expect(comparePage.toolbar.annotationChangesFilterBtn).toHaveText('1')
await expect(comparePage.toolbar.unclassifiedChangesFilterBtn).toHaveText('1')*/
await expect(comparePage.toolbar.unclassifiedChangesFilterBtn).toHaveText('1')

await expect(comparePage.swapper.leftTitle).toHaveText('path prefix: /api/v1/')
await expect(comparePage.swapper.rightTitle).toHaveText('path prefix: /api/v2/')

//! await expect(comparePage.compareContent.getOperationRow()).toHaveCount(4) //Issue TestCase-B-1442
await expect(comparePage.compareContent.getOperationRow()).toHaveCount(6) //Issue TestCase-B-1442
await expect.soft(getUserV1Row.changeSeverityIndicator).toHaveText('breaking')
await expect.soft(getUserV1Row.leftSummary.path).toHaveText(`${GET_USER_BY_NAME_V1.method}${GET_USER_BY_NAME_V1.path}`)
await expect.soft(getUserV1Row.leftSummary.changes).toBeHidden()
Expand All @@ -178,25 +178,25 @@ test.describe('12.1.4 Prefix grouping: Viewing', () => {
await expect.soft(createListV1Row.rightSummary.changes.breaking).toHaveText('Breaking: 1')
await expect.soft(createListV1Row.rightSummary.changes.risky).toBeHidden()
await expect.soft(createListV1Row.rightSummary.changes.deprecated).toHaveText('Deprecated: 1')
//! await expect.soft(createListV1Row.rightSummary.changes.nonBreaking).toHaveText('Non-breaking: 1') //Issue TestCase-B-1442
await expect.soft(createListV1Row.rightSummary.changes.annotation).toHaveText('Annotation: 2')
await expect.soft(createListV1Row.rightSummary.changes.nonBreaking).toHaveText('Non-breaking: 1') //Issue TestCase-B-1442
await expect.soft(createListV1Row.rightSummary.changes.annotation).toHaveText('Annotation: 1')
await expect.soft(createListV1Row.rightSummary.changes.unclassified).toHaveText('Unclassified: 1')
})

await test.step('Swap', async () => {
await comparePage.swapper.swapBtn.click()

// await expect(comparePage.toolbar.breakingChangesFilterBtn).toHaveText('2')
// await expect(comparePage.toolbar.riskyChangesFilterBtn).toHaveText('0')
// await expect(comparePage.toolbar.deprecatedChangesFilterBtn).toHaveText('2')
// await expect(comparePage.toolbar.nonBreakingChangesFilterBtn).toHaveText('2')
// await expect(comparePage.toolbar.annotationChangesFilterBtn).toHaveText('1')
// await expect(comparePage.toolbar.unclassifiedChangesFilterBtn).toHaveText('1')
await expect(comparePage.toolbar.breakingChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.riskyChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.deprecatedChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.nonBreakingChangesFilterBtn).toHaveText('2')
await expect(comparePage.toolbar.annotationChangesFilterBtn).toHaveText('1')
await expect(comparePage.toolbar.unclassifiedChangesFilterBtn).toHaveText('1')

await expect(comparePage.swapper.leftTitle).toHaveText('path prefix: /api/v2/')
await expect(comparePage.swapper.rightTitle).toHaveText('path prefix: /api/v1/')

//! await expect(comparePage.compareContent.getOperationRow()).toHaveCount(4) //Issue TestCase-B-1442
await expect(comparePage.compareContent.getOperationRow()).toHaveCount(6) //Issue TestCase-B-1442
await expect.soft(getUserV1Row.changeSeverityIndicator).toHaveText('non-breaking')
await expect.soft(getUserV1Row.leftSummary.path).toBeHidden()
await expect.soft(getUserV1Row.leftSummary.changes).toBeHidden()
Expand All @@ -210,19 +210,33 @@ test.describe('12.1.4 Prefix grouping: Viewing', () => {
await expect.soft(createListV1Row.rightSummary.changes.breaking).toHaveText('Breaking: 1')
await expect.soft(createListV1Row.rightSummary.changes.risky).toBeHidden
await expect.soft(createListV1Row.rightSummary.changes.deprecated).toHaveText('Deprecated: 1')
//! await expect.soft(createListV1Row.rightSummary.changes.nonBreaking).toHaveText('Non-breaking: 1') //Issue TestCase-B-1442
await expect.soft(createListV1Row.rightSummary.changes.annotation).toHaveText('Annotation: 2')
await expect.soft(createListV1Row.rightSummary.changes.nonBreaking).toHaveText('Non-breaking: 1') //Issue TestCase-B-1442
await expect.soft(createListV1Row.rightSummary.changes.annotation).toHaveText('Annotation: 1')
await expect.soft(createListV1Row.rightSummary.changes.unclassified).toHaveText('Unclassified: 1')
})

//Cover TestCase-A-10265 defect - operation comparison opening
Copy link
Contributor

@vOrigins vOrigins Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the next three steps could be moved to a separate test. Maybe should leave a TODO here.

await test.step('Open operation comparison', async () => {
await test.step('Open operation comparison for modified operation', async () => {
await comparePage.compareContent.getOperationRow(CREATE_LIST_OF_USERS_V1_UPDATED).click()

await expect(compareOperationsPage.docView).toBeVisible()
await expect(compareOperationsPage.swapper.leftTitle).toHaveText('path prefix: /api/v2/')
await expect(compareOperationsPage.swapper.rightTitle).toHaveText('path prefix: /api/v1/')
})

await test.step('Navigate back', async () => {
await compareOperationsPage.toolbar.backBtn.click()

await expect(comparePage.compareContent.getOperationRow()).toHaveCount(6)
})

await test.step('Open operation comparison for added operation', async () => {
await comparePage.compareContent.getOperationRow(GET_USER_BY_NAME_V1).click()

await expect(compareOperationsPage.docView).toBeVisible()
await expect(compareOperationsPage.swapper.leftTitle).toHaveText('path prefix: /api/v2/')
await expect(compareOperationsPage.swapper.rightTitle).toHaveText('path prefix: /api/v1/')
})
})

test('[P-GOP-6.2-N] Compare operations grouped by prefix - GraphQL',
Expand Down
Loading