fix push other workflow

Author: gn-dave-a

lua/neogit/popups/push/actions.lua

@@ -111,6 +111,14 @@ function M.to_elsewhere(popup)
   end
 end
 
+local function remove_prefix(str, prefix)
+  if str:sub(1, #prefix) == prefix then
+    return str:sub(#prefix + 1)
+  else
+    return str
+  end
+end
+
 function M.push_other(popup)
   local sources = util.merge({ popup.state.env.commit }, git.refs.list_local_branches(), git.refs.heads())
   local source = FuzzyFinderBuffer.new(sources):open_async { prompt_prefix = "push" }
@@ -119,17 +127,19 @@ function M.push_other(popup)
   end
 
   local destinations = git.refs.list_remote_branches()
-  for _, remote in ipairs(git.remote.list()) do
-    table.insert(destinations, 1, remote .. "/" .. source)
-  end
 
   local destination = FuzzyFinderBuffer.new(util.deduplicate(destinations))
     :open_async { prompt_prefix = "push " .. source .. " to" }
+
   if not destination then
     return
   end
 
   local remote, _ = git.branch.parse_remote_branch(destination)
+  --
+  -- destination is <remote>/branch-name, need to remove the remote prefix
+  destination = remove_prefix(destination, remote .. "/")
+
   push_to(popup:get_arguments(), remote, source .. ":" .. destination)
 end