materialize release_build_status view for performance

Author: syphar

.sqlx/query-5ecd90db215d7bf3178869a320176af53e2e45f860edd6b2bb42ed5b45ae4efa.json renamed to .sqlx/query-0b4084390b6c738c6f26c2dd13eff6ec8e7ea47c4d005d6cc00dbc60f69380cf.json

@@ -0,0 +1,25 @@
+DROP TABLE release_build_status;
+
+CREATE OR REPLACE VIEW release_build_status AS (
+  SELECT 
+    summary.id,
+    summary.last_build_time,
+    CASE 
+      WHEN summary.success_count > 0 THEN 'success'::build_status
+      WHEN summary.failure_count > 0 THEN 'failure'::build_status
+      ELSE 'in_progress'::build_status
+    END as build_status
+      
+  FROM (
+    SELECT
+      r.id,
+      MAX(b.build_time) as last_build_time,
+      SUM(CASE WHEN b.build_status = 'success' THEN 1 ELSE 0 END) as success_count,
+      SUM(CASE WHEN b.build_status = 'failure' THEN 1 ELSE 0 END) as failure_count
+    FROM 
+      releases as r
+      LEFT OUTER JOIN builds AS b on b.rid = r.id 
+    GROUP BY r.id
+  ) as summary
+);
+

.sqlx/query-e8f8c3649576bcba99393a2e78c9f892efba0a451bb14fff77876ca250b0fab1.json renamed to .sqlx/query-162c05df1f44bb48d087b6e6e4b3a8ab868b6d0cc20143b176522c0791a7023c.json

@@ -0,0 +1,32 @@
+DROP VIEW release_build_status;
+CREATE TABLE release_build_status (
+    rid INTEGER NOT NULL PRIMARY KEY,
+    last_build_time timestamp with time zone,
+    build_status build_status NOT NULL
+);
+
+
+INSERT INTO release_build_status(rid, last_build_time, build_status) 
+SELECT 
+summary.id,
+summary.last_build_time,
+CASE 
+  WHEN summary.success_count > 0 THEN 'success'::build_status
+  WHEN summary.failure_count > 0 THEN 'failure'::build_status
+  ELSE 'in_progress'::build_status
+END as build_status
+  
+FROM (
+    SELECT
+      r.id,
+      MAX(b.build_time) as last_build_time,
+      SUM(CASE WHEN b.build_status = 'success' THEN 1 ELSE 0 END) as success_count,
+      SUM(CASE WHEN b.build_status = 'failure' THEN 1 ELSE 0 END) as failure_count
+    FROM 
+      releases as r
+      LEFT OUTER JOIN builds AS b on b.rid = r.id 
+    GROUP BY r.id
+) as summary;
+
+CREATE INDEX release_build_status_last_build_time_idx ON release_build_status USING btree (last_build_time DESC);
+CREATE INDEX release_build_status_build_status_idx ON release_build_status USING btree (build_status);

.sqlx/query-649f22aaffbd35cb00a820a68677797e8bbde159b10d04e3945520a61b63ecb0.json

@@ -125,6 +125,8 @@ pub(crate) async fn add_package_into_database(
         .await
         .context("couldn't update latest version id")?;
 
+    update_build_status(conn, release_id).await?;
+
     Ok(release_id)
 }
 
@@ -144,6 +146,44 @@ pub async fn update_latest_version_id(conn: &mut sqlx::PgConnection, crate_id: i
     Ok(())
 }
 
+pub async fn update_build_status(conn: &mut sqlx::PgConnection, release_id: i32) -> Result<()> {
+    sqlx::query!(
+        "INSERT INTO release_build_status(rid, last_build_time, build_status)
+         SELECT
+         summary.id,
+         summary.last_build_time,
+         CASE
+           WHEN summary.success_count > 0 THEN 'success'::build_status
+           WHEN summary.failure_count > 0 THEN 'failure'::build_status
+           ELSE 'in_progress'::build_status
+         END as build_status
+
+         FROM (
+             SELECT
+               r.id,
+               MAX(b.build_time) as last_build_time,
+               SUM(CASE WHEN b.build_status = 'success' THEN 1 ELSE 0 END) as success_count,
+               SUM(CASE WHEN b.build_status = 'failure' THEN 1 ELSE 0 END) as failure_count
+             FROM
+               releases as r
+               LEFT OUTER JOIN builds AS b on b.rid = r.id
+             WHERE
+               r.id = $1
+             GROUP BY r.id
+         ) as summary
+
+         ON CONFLICT (rid) DO UPDATE
+         SET
+             last_build_time = EXCLUDED.last_build_time,
+             build_status=EXCLUDED.build_status",
+        release_id,
+    )
+    .execute(&mut *conn)
+    .await?;
+
+    Ok(())
+}
+
 async fn crate_id_from_release_id(conn: &mut sqlx::PgConnection, release_id: i32) -> Result<i32> {
     Ok(sqlx::query_scalar!(
         "SELECT crate_id
@@ -208,6 +248,8 @@ pub(crate) async fn add_build_into_database(
     .fetch_one(&mut *conn)
     .await?;
 
+    update_build_status(conn, release_id).await?;
+
     let crate_id = crate_id_from_release_id(&mut *conn, release_id).await?;
     update_latest_version_id(&mut *conn, crate_id)
         .await

.sqlx/query-2e8ab3494453908d26decae9f9f64741c42f9476ed8573511fe141883b86482d.json renamed to .sqlx/query-65f40f6603b1f3e736566c3d4e275bb47f6ebc389b0aa61f7732d1f354dc5259.json

@@ -7,7 +7,7 @@ pub(crate) use self::add_package::{
     add_build_into_database, add_doc_coverage, add_package_into_database,
 };
 pub use self::{
-    add_package::update_crate_data_in_database,
+    add_package::{update_build_status, update_crate_data_in_database},
     delete::{delete_crate, delete_version},
     file::{add_path_into_database, add_path_into_remote_archive},
     overrides::Overrides,

.sqlx/query-7e833553cf419d8fbc3a5a0c504f0af2fa3d4aaca158c3b616f2e683a943bccb.json

@@ -190,7 +190,7 @@ impl CrateDetails {
                 doc_coverage.total_items_needing_examples,
                 doc_coverage.items_with_examples
             FROM releases
-            INNER JOIN release_build_status ON releases.id = release_build_status.id
+            INNER JOIN release_build_status ON releases.id = release_build_status.rid
             INNER JOIN crates ON releases.crate_id = crates.id
             LEFT JOIN doc_coverage ON doc_coverage.release_id = releases.id
             LEFT JOIN repositories ON releases.repository_id = repositories.id
@@ -380,7 +380,7 @@ pub(crate) async fn releases_for_crate(
              releases.rustdoc_status,
              releases.target_name
          FROM releases
-         INNER JOIN release_build_status ON releases.id = release_build_status.id
+         INNER JOIN release_build_status ON releases.id = release_build_status.rid
          WHERE
              releases.crate_id = $1"#,
         crate_id,
@@ -695,7 +695,10 @@ mod tests {
         assert_cache_control, assert_redirect, assert_redirect_cached, async_wrapper, wrapper,
         FakeBuild, TestDatabase, TestEnvironment,
     };
-    use crate::{db::types::BuildStatus, registry_api::CrateOwner};
+    use crate::{
+        db::{types::BuildStatus, update_build_status},
+        registry_api::CrateOwner,
+    };
     use anyhow::Error;
     use kuchikiki::traits::TendrilSink;
     use reqwest::StatusCode;
@@ -712,7 +715,7 @@ mod tests {
             SELECT build_status as "build_status!: BuildStatus"
             FROM crates
             INNER JOIN releases ON crates.id = releases.crate_id
-            INNER JOIN release_build_status ON releases.id = release_build_status.id
+            INNER JOIN release_build_status ON releases.id = release_build_status.rid
             WHERE crates.name = $1 AND releases.version = $2"#,
             name,
             version
@@ -1800,7 +1803,8 @@ mod tests {
     #[test]
     fn test_build_status_no_builds() {
         async_wrapper(|env| async move {
-            env.async_fake_release()
+            let release_id = env
+                .async_fake_release()
                 .await
                 .name("dummy")
                 .version("0.1.0")
@@ -1812,6 +1816,8 @@ mod tests {
                 .execute(&mut *conn)
                 .await?;
 
+            update_build_status(&mut conn, release_id).await?;
+
             assert_eq!(
                 release_build_status(&mut conn, "dummy", "0.1.0").await,
                 BuildStatus::InProgress