fix(windows): test

Author: triniwiz

lib/common/file-system.ts

@@ -327,7 +327,12 @@ export class FileSystem implements IFileSystem {
 
 		// MobileApplication.app is resolved as a directory on Mac,
 		// therefore we need to copy it recursively as it's not a single file.
-		shelljs.cp("-rf", sourceFileName, destinationFileName);
+		// On Windows, shelljs glob expansion requires forward slashes.
+		const normalizedSource =
+			process.platform === "win32"
+				? sourceFileName.replace(/\\/g, "/")
+				: sourceFileName;
+		shelljs.cp("-rf", normalizedSource, destinationFileName);
 
 		const err = shelljs.error();
 

lib/common/test/unit-tests/mobile/devices-service.ts

@@ -201,6 +201,10 @@ function createTestInjector(): IInjector {
 	testInjector.register("iOSDeviceDiscovery", IOSDeviceDiscoveryStub);
 	testInjector.register("iOSSimulatorDiscovery", IOSSimulatorDiscoveryStub);
 	testInjector.register("androidDeviceDiscovery", AndroidDeviceDiscoveryStub);
+	class WindowsDeviceDiscoveryStub extends EventEmitter {
+		public async startLookingForDevices(): Promise<void> {}
+	}
+	testInjector.register("windowsDeviceDiscovery", WindowsDeviceDiscoveryStub);
 	testInjector.register("staticConfig", { CLIENT_NAME: "unit-tests" });
 	testInjector.register("devicePlatformsConstants", DevicePlatformsConstants);
 	testInjector.register("androidEmulatorServices", AndroidEmulatorServices);

lib/services/platform/add-platform-service.ts

@@ -55,7 +55,7 @@ export class AddPlatformService implements IAddPlatformService {
 				"package.json",
 			);
 
-			if (!frameworkDirPath || !this.$fs.exists(frameworkPackageJsonPath)) {
+			if (!this.$fs.exists(frameworkPackageJsonPath)) {
 				throw new Error(
 					`Installed framework package.json not found at ${frameworkPackageJsonPath}`,
 				);

test/ios-project-service.ts

@@ -128,6 +128,10 @@ function createTestInjector(
 	testInjector.register("iOSSimulatorDiscovery", IOSSimulatorDiscoveryMock);
 	testInjector.register("iOSSimResolver", {});
 	testInjector.register("androidDeviceDiscovery", AndroidDeviceDiscovery);
+	class WindowsDeviceDiscoveryStub extends DeviceDiscovery {
+		public async startLookingForDevices(): Promise<void> {}
+	}
+	testInjector.register("windowsDeviceDiscovery", WindowsDeviceDiscoveryStub);
 	testInjector.register("messages", Messages);
 	testInjector.register("mobileHelper", MobileHelper);
 	testInjector.register("deviceLogProvider", DeviceLogProvider);

test/plugins-service.ts

@@ -109,6 +109,7 @@ function createTestInjector() {
 	testInjector.register("sysInfo", {});
 	testInjector.register("androidProjectService", AndroidProjectService);
 	testInjector.register("iOSProjectService", {});
+	testInjector.register("windowsProjectService", {});
 	testInjector.register("devicesService", {});
 	testInjector.register("projectDataService", ProjectDataService);
 	testInjector.register("prompter", {});

test/project-changes-service.ts

@@ -35,6 +35,7 @@ class ProjectChangesServiceTest extends BaseServiceTest {
 		this.injector.register("platformsDataService", PlatformsDataService);
 		this.injector.register("androidProjectService", {});
 		this.injector.register("iOSProjectService", {});
+		this.injector.register("windowsProjectService", {});
 		this.injector.register("fs", FileSystem);
 		this.injector.register("devicePlatformsConstants", {});
 		this.injector.register("devicePlatformsConstants", {});

test/services/platform/add-platform-service.ts

@@ -28,7 +28,8 @@ function createTestInjector() {
 	injector.register("tempService", stubs.TempServiceStub);
 
 	const fs = injector.resolve("fs");
-	fs.exists = () => false;
+	fs.exists = (path: string) => path.includes("package.json");
+	fs.readJson = () => ({ version: "4.2.0" });
 
 	return injector;
 }