fix: memory leak on ArgConverter::ConstructObject

NathanWalker · NathanWalker · commit 1129d15fb47d · 2022-07-21T20:27:20.000-07:00
diff --git a/NativeScript/runtime/ArgConverter.mm b/NativeScript/runtime/ArgConverter.mm
@@ -341,7 +341,7 @@
         tns::SetValue(isolate, thiz, wrapper);
         std::shared_ptr<Persistent<Value>> poThiz = ObjectManager::Register(context, thiz);
         cache->Instances.emplace(result, poThiz);
-        [result retain];
+        // [result retain];
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@`
`341`	`341`	`tns::SetValue(isolate, thiz, wrapper);`
`342`	`342`	`std::shared_ptr<Persistent<Value>> poThiz = ObjectManager::Register(context, thiz);`
`343`	`343`	`cache->Instances.emplace(result, poThiz);`
`344`		`- [result retain];`
	`344`	`+ // [result retain];`
`345`	`345`	`}`
`346`	`346`	`}`
`347`	`347`