Addressed some comments in PR review

Author: PanayotCankov

runtime/src/main/java/com/tns/AppConfig.java

@@ -1,14 +1,12 @@
 package com.tns;
 
 import java.io.File;
-
 import org.json.JSONObject;
-
 import android.os.Build;
 import android.util.Log;
 
 class AppConfig {
-    private enum KnownKeys {
+    protected enum KnownKeys {
         V8FlagsKey("v8Flags", "--expose_gc"),
         CodeCacheKey("codeCache", false),
         HeapSnapshotScriptKey("heapSnapshotScript", ""),
@@ -18,7 +16,7 @@ private enum KnownKeys {
         MemoryCheckInterval("memoryCheckInterval", 0),
         FreeMemoryRatio("freeMemoryRatio", 0.0),
         Profiling("profiling", ""),
-        MarkingMode("markingMode", com.tns.MarkingMode.values()[0]);
+        MarkingMode("markingMode", com.tns.MarkingMode.full);
 
         private final String name;
         private final Object defaultValue;
@@ -52,7 +50,7 @@ public AppConfig(File appDir) {
         try {
             rootObject = FileSystem.readJSONFile(packageInfo);
             if (rootObject != null) {
-                if (rootObject.has(KnownKeys.Profiling.name())) {
+                if (rootObject.has(KnownKeys.Profiling.getName())) {
                     String profiling = rootObject.getString(KnownKeys.Profiling.getName());
                     values[KnownKeys.Profiling.ordinal()] = profiling;
                 }
@@ -92,9 +90,12 @@ public AppConfig(File appDir) {
                     }
                     if (androidObject.has(KnownKeys.MarkingMode.getName())) {
                         try {
-                            String value = androidObject.getString(KnownKeys.MarkingMode.getName());
-                            values[KnownKeys.MarkingMode.ordinal()] = MarkingMode.valueOf(value);
-                        } catch(Throwable e) {
+                            String markingModeString = androidObject.getString(KnownKeys.MarkingMode.getName());
+                            MarkingMode markingMode = MarkingMode.valueOf(markingModeString);
+                            values[KnownKeys.MarkingMode.ordinal()] = markingMode;
+                        } catch(Exception e) {
+                            e.printStackTrace();
+                            Log.v("JS", "Failed to parse marking mode. The default " + ((MarkingMode)KnownKeys.MarkingMode.getDefaultValue()).name() + " will be used.");
                         }
                     }
                 }
@@ -131,5 +132,6 @@ public double getFreeMemoryRatio() {
     public String getProfilingMode() {
         return (String)values[KnownKeys.Profiling.ordinal()];
     }
+
     public MarkingMode getMarkingMode() { return (MarkingMode)values[KnownKeys.MarkingMode.ordinal()]; }
 }

runtime/src/main/java/com/tns/Runtime.java

@@ -207,7 +207,7 @@ public int getMarkingModeOrdinal() {
         if (staticConfiguration != null && staticConfiguration.appConfig != null) {
             return staticConfiguration.appConfig.getMarkingMode().ordinal();
         } else {
-            return MarkingMode.values()[0].ordinal();
+            return ((MarkingMode)AppConfig.KnownKeys.MarkingMode.getDefaultValue()).ordinal();
         }
     }
 

runtime/src/main/jni/ObjectManager.cpp

@@ -299,7 +299,7 @@ void ObjectManager::JSObjectFinalizer(Isolate* isolate, ObjectWeakCallbackState*
     Persistent<Object>* po = callbackState->target;
     auto jsInstanceInfo = GetJSInstanceInfoFromRuntimeObject(po->Get(m_isolate));
 
-    if (!jsInstanceInfo) {
+    if (jsInstanceInfo == nullptr) {
         po->Reset();
         return;
     }