Skip to content

Commit 5a7dd0d

Browse files
authored
Fix PHP 8.4 builds on Windows (#131)
* fix: 7za | tar not working on bash shell * fix: php-bin directory does not exist at first build * fix: update extension list with essential dependencies * fix: temp fix to windows build * Revert "fix: temp fix to windows build" This reverts commit 13253b7. * fix: patched a patch. Is it stupid if it works? * fix: patched a patch. Is it stupid if it works?
1 parent 777e4d4 commit 5a7dd0d

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

.github/workflows/build-php.yml

+18-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ jobs:
3535
git clone https://github.com/crazywhalecc/static-php-cli.git
3636
cd static-php-cli
3737
git checkout main
38-
cd ../php-bin
38+
cd ../
39+
[ ! -d php-bin ] && mkdir -p php-bin
40+
cd php-bin
3941
4042
- shell: bash
4143
run: |
@@ -118,8 +120,22 @@ jobs:
118120
./bin/spc download --with-php=${{ matrix.version }} --for-extensions "${{ env.PHP_EXTENSIONS }}" --prefer-pre-built
119121
cd ../php-bin
120122
121-
- name: Build PHP
123+
- name: Patch for windows 8.4 builds
122124
shell: bash
125+
run: |
126+
cd ../static-php-cli
127+
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_80.patch
128+
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_81.patch
129+
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_82.patch
130+
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_83.patch
131+
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_84.patch
132+
sed -i '18d' downloads/micro/patches/cli_static_84.patch
133+
sed -i 's/+1160,11/+1160,10/' downloads/micro/patches/cli_static_84.patch
134+
rm -f downloads/micro/patches/cli_static.patch
135+
cat downloads/micro/patches/cli_static_84.patch
136+
cd ../php-bin
137+
138+
- name: Build PHP
123139
run: |
124140
cd ../static-php-cli
125141
./bin/spc build --build-cli "${{ env.PHP_EXTENSIONS }}"

php-extensions.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bcmath,ctype,curl,dom,fileinfo,filter,gd,mbstring,opcache,openssl,pdo,pdo_sqlite,phar,session,simplexml,sockets,sqlite3,tokenizer,xml,zip,zlib
1+
bcmath,bz2,ctype,curl,dom,fileinfo,filter,gd,iconv,mbstring,opcache,openssl,pdo,pdo_sqlite,phar,session,simplexml,sockets,sqlite3,tokenizer,xml,zip,zlib

0 commit comments

Comments
 (0)