Feature handleMatchFailuresAsNew [MRA-841] (#367) (#368)

* Add matchFailuresAsNew query parameter
* NOTE: requires validator ^3.8.0 to be usable

* Update deps

* 3.5.0-alpha.1

Author: ammsalme

package-lock.json

@@ -14,7 +14,7 @@
 		"url": "[email protected]:natlibfi/melinda-rest-api-http.git"
 	},
 	"license": "MIT",
-	"version": "3.4.1",
+	"version": "3.5.0-alpha.1",
 	"main": "dist/index.js",
 	"engines": {
 		"node": ">=18"
@@ -44,7 +44,7 @@
 		"mongo-sanitize": "^1.1.0",
 		"nodemon": "^3.1.9",
 		"passport": "^0.7.0",
-		"uuid": "^11.0.5"
+		"uuid": "^11.1.0"
 	},
 	"devDependencies": {
 		"@babel/cli": "^7.26.4",

package.json

@@ -70,6 +70,14 @@
               "default": false
             }
           },
+          {
+            "name": "matchFailuresAsNew",
+            "description": "Handle merge jobs where are all matches fail matchValidation as new.",
+            "in": "query",
+            "schema": {
+              "type": "boolean"
+            }
+          },
           {
             "name": "cataloger",
             "description": "Cataloger name to use while operating on a record. Note: requires admin rights to use",
@@ -309,6 +317,14 @@
               "default": false
             }
           },
+          {
+            "name": "matchFailuresAsNew",
+            "description": "Handle merge jobs where are all matches fail matchValidation as new.",
+            "in": "query",
+            "schema": {
+              "type": "boolean"
+            }
+          },
           {
             "name": "cataloger",
             "description": "Cataloger name to use while operating on a record. Note: requires admin rights to use",

src/api.json

@@ -231,6 +231,12 @@ paths:
           schema:
             type: boolean
             default: false
+        - name: matchFailuresAsNew
+          description: >-
+            Handle merge jobs where are all matches fail matchValidation as new
+          in: query
+          schema:
+            type: boolean
         - name: cataloger
           description: >-
             Cataloger name to use while operating on a record. Note: requires admin rights to use
@@ -404,6 +410,12 @@ paths:
           schema:
             type: boolean
             default: false
+        - name: matchFailuresAsNew
+          description: >-
+            Handle merge jobs where are all matches fail matchValidation as new
+          in: query
+          schema:
+            type: boolean
         - name: pRejectFile
           description: Error log file location
           in: query

src/api.yaml

@@ -328,7 +328,7 @@ export default async function ({mongoUri, amqpUrl, allowedLibs}) {
     const paramUnique = queryParams.unique ? parseBoolean(queryParams.unique) : undefined;
     const paramMerge = queryParams.merge ? parseBoolean(queryParams.merge) : undefined;
     const paramSkipLowValidation = queryParams.skipLowValidation ? parseBoolean(queryParams.skipLowValidateLow) : undefined;
-
+    const paramMatchFailuresAsNew = queryParams.matchFailuresAsNew ? parseBoolean(queryParams.matchFailuresAsNew) : undefined;
 
     if (paramValidate === false && (paramUnique || paramMerge)) {
       logger.debug(`Query parameter validate=0 is not valid with query parameters unique=1 and/or merge=1`);
@@ -354,6 +354,7 @@ export default async function ({mongoUri, amqpUrl, allowedLibs}) {
       failOnError: queryParams.failOnError === undefined ? false : parseBoolean(queryParams.failOnError),
       // bulk skips changes that won't change the database record as default
       skipNoChangeUpdates: queryParams.skipNoChangeUpdates === undefined ? true : parseBoolean(queryParams.skipNoChangeUpdates),
+      matchFailuresAsNew: paramMatchFailuresAsNew,
       prio: false
     };
 

src/interfaces/bulk.js

@@ -116,6 +116,7 @@ export default async ({sruUrl, amqpUrl, mongoUri, pollWaitTime, recordType, requ
         failOnError: null,
         // Prio forces updates as default, even if the update would not make changes to the database record
         skipNoChangeUpdates: req.query.skipNoChangeUpdates === undefined ? false : parseBoolean(req.query.skipNoChangeUpdates),
+        matchFailuresAsNew: req.query.matchFailuresAsNew === undefined ? undefined : parseBoolean(req.query.matchFailuresAsNew),
         prio: true
       };
 

src/routes/prio.js

@@ -24,6 +24,7 @@ export function checkQueryParams(req, res, next) {
     {name: 'skipLowValidation', value: queryParams.skipLowValidation ? (/^(?:1|0|true|false)$/ui).test(queryParams.skipLowValidation) : true},
     {name: 'failOnError', value: queryParams.failOnError ? (/^(?:1|0|true|false)$/ui).test(queryParams.failOnError) : true},
     {name: 'skipNoChangeUpdates', value: queryParams.skipNoChangeUpdates ? (/^(?:1|0|true|false)$/ui).test(queryParams.skipNoChangeUpdates) : true},
+    {name: 'maatchFailuresAsNew', value: queryParams.matchFailuresAsNew ? (/^(?:1|0|true|false)$/ui).test(queryParams.matchFailuresAsNew) : true},
     {name: 'pRejectFile', value: queryParams.pRejectFile ? (/^[a-z|A-Z|0-9|/|.|_|-]{0,100}$/u).test(queryParams.pRejectFile) : true},
     {name: 'pLogFile', value: queryParams.pLogFile ? (/^[a-z|A-Z|0-9|/|.|_|-]{0,100}$/u).test(queryParams.pLogFile) : true},
     {name: 'pCatalogerIn', value: queryParams.pCatalogerIn ? (/^(?:0|false|undefined|[A-Z|0-9|_|-]{0,10}$)/u).test(queryParams.pCatalogerIn) : true},