Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support AST with isNull function #12187

Open
viadea opened this issue Feb 20, 2025 · 1 comment
Open

[FEA] Support AST with isNull function #12187

viadea opened this issue Feb 20, 2025 · 1 comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@viadea
Copy link
Collaborator

viadea commented Feb 20, 2025

I wish we can avoid below CPU fallback which is related to AST + isNull

    !Exec <BroadcastHashJoinExec> cannot run on GPU because not all expressions can be replaced
                !Expression <IsNull> isnull(xxx) cannot run on GPU because AST is required and this expression does not support AST
@viadea viadea added ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 20, 2025
@revans2
Copy link
Collaborator

revans2 commented Feb 20, 2025

isNull is supported by AST already so this should be simple to add.

https://github.com/rapidsai/cudf/blob/163e27b4785a0890323bc0ff9c7a27657d23e0d3/java/src/main/java/ai/rapids/cudf/ast/UnaryOperator.java#L27

The we just need to update GpuIsNull so that it provides a way to convert it to AST and that we can properly tag it for AST support. As a part of that we need to test to see what CUDF actually does, or does not support for AST isNull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants