Various fixes for dynamic kernel loading #3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
sacpis
reviewed
Oct 10, 2025
sacpis
reviewed
Oct 10, 2025
sacpis
reviewed
Oct 10, 2025
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
Oct 24, 2025
sacpis
approved these changes
Oct 24, 2025
|
I'm going to very likely revert this with my changes. Yes. I'll revert these changes in my total rewrite of the python handling of builders, decorators, compilation, and launching. |
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this pull request
Oct 31, 2025
Signed-off-by: Eric Schweitz <[email protected]>
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this pull request
Oct 31, 2025
The current implementation of the Python handling of CUDA-Q has baked in
various attempts to deal with the language coupling between Python and
CUDA-Q kernels. These solutions have been accumulating and making it more
and more difficult to work on the Python implementation.
These changes are a total rewrite to bring the Python implementation more
closely aligned with the C++ implementation.
Changes:
- The kernel builder and kernel decorator are fundamentally different
and will no longer share a duck-typed interface. It doesn't work well.
The builder assembles a CUDA-Q kernel dynamically. As such all symbolic
references are known immediately. The decorator converts a static AST
of code into a CUDA-Q kernel. Symbolic references are either local or
not. Non-local symbols are unknown at the point the decorator is
processed. All non-local symbols in a decorator are recorded with the
decorator itself and lambda lifted as actual arguments.
- MLIR requires that symbols be uniqued. The previous implementation ignored
this requirement.
- Lazy state maintenance in Python and the C++ runtime layers is buggy and
not needed. It is removed. This includes dangling MLIR bindings from the
AST bridge's python MLIR bindings.
- Kernels are no longer built with assumptions, then rebuilt when those
guesses prove wrong. Kernels are no longer built and rebuilt for different
steps in the process. A kernel decorator builds a target agnostic, context
independent kernel, and saves that MLIR ModuleOp under a unique name.
- Launch scenarios have been reworked and consolidated to use the ModuleOp
directly instead of shuffling between string representations (possibly
under maps that were not thread-safe) and ModuleOp instances.
- Every step of the process creating a brand new MLIRContext and loading all
the dialects into that context, etc. is removed. This is done once and the
Python interpreter uses the same context to build all modules.
These changes also revert some work on the bridge meant to fix bugs that was
in conflict. This includes NVIDIA#3507, NVIDIA#3545.
Signed-off-by: Eric Schweitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Allow override in
registerDeviceKernel(2) Clear kernel decorator's
module(parsed from walking the Python AST) as we switch target.The lack of this
moduleattribute tells the decorator to perform a propercompile().Note: Other global maps might be populated during kernel constructor (i.e., as Python sees kernels); hence might not be safe to clear.
(3) Python to honor the default simulator environment variable for hardware target emulation. It was hardcoded to
qppfor those targets that don't define a simulator.