Skip to content

Small mismatch in user info from /proposal vs /person #237

@vshekar

Description

@vshekar

The "users" key in the /v1/proposal's response is not the same as the response in /person

For example: https://api.nsls2.bnl.gov/v1/proposal/320326
The users section in the url above has my user info:

{
  "first_name": "Venkateswaran",
  "last_name": "Shekar",
  "email": "vshekar1@bnl.gov",
  "bnl_id": "27196",
  "username": "vshekar1",
  "is_pi": false,
  "orcid": "0000-0001-5625-2475"
}

While the response in: https://api.nsls2.bnl.gov/v1/person/username/vshekar1

{
  "firstname": "Venkateswaran",
  "lastname": "Shekar",
  "email": "vshekar1@bnl.gov",
  "username": "vshekar1",
  "bnl_id": "27196",
  "bnl_employee": true,
  "institution": "Brookhaven National Laboratory",
  "orcid": null,
  "globus_username": null,
  "pass_unique_id": null,
  "account_locked": null,
  "cyber_agreement_signed": "2022-08-01T00:00:00",
  "facility_code": null,
  "facility_name": null,
  "citizenship": null
}

Would be good to standardize first_name + last_name key names in both responses. Additionally the orcid is not available in /v1/person. Finally if user "institution" is available in the proposal response, it would be really useful for the lambda project.

Happy to make a PR so address them

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions