Skip to content

When loading a dataURL all the existing variables should be cleared #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpatiny opened this issue Mar 29, 2014 · 1 comment
Open

Comments

@lpatiny
Copy link
Collaborator

lpatiny commented Mar 29, 2014

Currently when changing of views and reloading data the existing variables are not cleared.

For example you can search for benzene by structure on:

http://visualizer.epfl.ch/cheminfo/visualizer_201403290653/index.html?config=..%2F_design%2Fflavor%2F_list%2Fconfig%2Falldocs%3Fkey%3D%22biooriented%22&dataURL=%2Fcheminfo%2F4b7669c5ec0a15e6fb3994f53b952eeb%2Fdata.json&viewURL=%2Fcheminfo%2F4b7669c5ec0a15e6fb3994f53b952eeb%2Fview.json

And then switch the view to IR -> Browse spectra. The data will still be there while there is a dataURL so we expect to reload all the data.

Moreover after changing of view if you make another query the result does not appear in the table. You need to reload the page so that it works.

@targos
Copy link
Collaborator

targos commented Mar 31, 2014

There may be an issue with the doView and doData callbacks (entrypoint.js):

  • doView : calls "this" in the window context
  • doData : never receives the "reloading" parameter
    It could also explain why Versioning.setViewJSON recreates the grid (Context menu duplication #62)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants