Add upstream cookie support #683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2022 15:33
…nd server cookie to the upstream query
…rough search through an edns_option list
TCY16
changed the title
added 8 commits
May 30, 2022 15:38
…in the rrdef enum
TCY16
force-pushed
the
features/upstream-cookies
branch
from
f5f8060 to
aebf1db
Compare
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
So I noticed some debug and todo comments and debug log prints, and made some suggestions in the items. The code looks nice. The .rpl file does not exercise the outside_network code, but it is not that big a part of the code.
Create server cookies for clients that send client cookies. Needs to be turned on in the config file with: answer-cookie: yes A cookie-secret can be configured for anycast setups. Also adds an access control list that will allow queries with either a valid cookie or over a stateful transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.