Release 0.6.2 - Fix issue with determining creation time on certain platforms.

Author: Tim Bruijnzeels

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name    = "krill"
-version = "0.6.1"
+version = "0.6.2"
 edition = "2018"
 authors = [ "The NLnet Labs RPKI team <[email protected]>" ]
 description = "Resource Public Key Infrastructure (RPKI) daemon"

Cargo.toml

@@ -3,6 +3,14 @@
 Please see [here](https://github.com/NLnetLabs/krill/projects?query=is%3Aopen+sort%3Aname-asc)
 for planned releases.
 
+## 0.6.2 Release 'That was even faster!'
+
+So, as it turns out.. the code used to determine the age of snapshot files used in the previous
+release was not safe on all platforms. This release fixes this!
+
+Users who upgraded to 0.6.1 and see messages like: "Creation time is not available on this
+platform currently" in their logs, please upgrade!
+
 ## 0.6.1 Release 'That was fast!'
 
 This release fixes an issue where the Krill Repository Server deleted RRDP snapshot files as soon

Changelog.md

@@ -1,7 +1,7 @@
 openapi: "3.0.2"
 info:
   title: Krill RPKI Server API
-  version: 0.6.1
+  version: 0.6.2
   description: |
     # Introduction
     Welcome to the documentation for the Krill server API, a JSON based

doc/openapi.yaml

@@ -1,4 +1,4 @@
-pub const KRILL_VERSION: &str = "0.6.1";
+pub const KRILL_VERSION: &str = "0.6.2";
 pub const KRILL_SERVER_APP: &str = "Krill";
 pub const KRILL_CLIENT_APP: &str = "Krill Client";
 

src/constants.rs

@@ -264,7 +264,7 @@ impl RrdpServer {
             } else {
                 let path = entry.path();
                 if path.is_dir() {
-                    fs::remove_dir_all(path)?;
+                    let _best_effort_rm = fs::remove_dir_all(path);
                 }
             }
         }
@@ -286,9 +286,9 @@ impl RrdpServer {
                 if let Some(last) = self.notification.last_delta() {
                     if serial < last {
                         if path.is_dir() {
-                            fs::remove_dir_all(path)?;
+                            let _best_effort_rm = fs::remove_dir_all(path);
                         } else {
-                            fs::remove_file(path)?;
+                            let _best_effort_rm = fs::remove_file(path);
                         }
 
                         continue;
@@ -301,24 +301,25 @@ impl RrdpServer {
                     let snapshot_path =
                         Self::new_snapshot_path(&self.rrdp_base_dir, &self.session, serial);
                     if snapshot_path.exists() {
-                        let meta = fs::metadata(&snapshot_path)?;
-                        let created = meta.created()?;
-
-                        let now = SystemTime::now();
-                        if let Ok(duration) = now.duration_since(created) {
-                            let minutes_old = duration.as_secs() / 60;
-                            if minutes_old >= REPOSITORY_RRDP_SNAPSHOT_RETAIN_MINS {
-                                fs::remove_file(snapshot_path)?;
+                        if let Ok(meta) = fs::metadata(&snapshot_path) {
+                            if let Ok(created) = meta.created() {
+                                let now = SystemTime::now();
+                                if let Ok(duration) = now.duration_since(created) {
+                                    let minutes_old = duration.as_secs() / 60;
+                                    if minutes_old >= REPOSITORY_RRDP_SNAPSHOT_RETAIN_MINS {
+                                        let _best_effort_rm = fs::remove_file(snapshot_path);
+                                    }
+                                }
                             }
                         }
                     }
                 }
             } else {
                 // clean up dirs or files under the base dir which are not sessions
                 if path.is_dir() {
-                    fs::remove_dir_all(path)?;
+                    let _best_effort_rm = fs::remove_dir_all(path);
                 } else {
-                    fs::remove_file(path)?;
+                    let _best_effort_rm = fs::remove_file(path);
                 }
             }
         }