Skip to content

Commit c0dee07

Browse files
committed
es 7.4.0 support
1 parent 21113e8 commit c0dee07

File tree

5 files changed

+31
-26
lines changed

5 files changed

+31
-26
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jdk:
44
- openjdk8
55

66
before_install:
7-
- wget https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-7.3.2-amd64.deb && sudo dpkg -i --force-confnew elasticsearch-7.3.2-amd64.deb
7+
- wget https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-7.4.0-amd64.deb && sudo dpkg -i --force-confnew elasticsearch-7.4.0-amd64.deb
88
- sudo cp ./src/test/resources/elasticsearch.yml /etc/elasticsearch/elasticsearch.yml
99
- sudo cat /etc/elasticsearch/elasticsearch.yml
1010
- sudo java -version

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>org.nlpcn</groupId>
55
<artifactId>elasticsearch-sql</artifactId>
6-
<version>7.3.2.0</version>
6+
<version>7.4.0.0</version>
77
<packaging>jar</packaging>
88
<description>Query elasticsearch using SQL</description>
99
<name>elasticsearch-sql</name>
@@ -44,7 +44,7 @@
4444
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
4545
<runSuite>**/MainTestSuite.class</runSuite>
4646
<elasticsearch.plugin.name>sql</elasticsearch.plugin.name>
47-
<elasticsearch.version>7.3.2</elasticsearch.version>
47+
<elasticsearch.version>7.4.0</elasticsearch.version>
4848
<elasticsearch.plugin.classname>org.elasticsearch.plugin.nlpcn.SqlPlug</elasticsearch.plugin.classname>
4949
<druid.version>1.1.16</druid.version>
5050
<guava.version>15.0</guava.version>

src/main/java/org/elasticsearch/plugin/nlpcn/RestSqlAction.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,32 +3,38 @@
33
import org.apache.logging.log4j.LogManager;
44
import org.apache.logging.log4j.Logger;
55
import org.elasticsearch.client.node.NodeClient;
6-
import org.elasticsearch.common.settings.Settings;
76
import org.elasticsearch.common.xcontent.XContentParser;
87
import org.elasticsearch.common.xcontent.XContentType;
98
import org.elasticsearch.plugin.nlpcn.executors.ActionRequestRestExecuterFactory;
109
import org.elasticsearch.plugin.nlpcn.executors.RestExecutor;
11-
import org.elasticsearch.rest.*;
10+
import org.elasticsearch.rest.BaseRestHandler;
11+
import org.elasticsearch.rest.BytesRestResponse;
12+
import org.elasticsearch.rest.RestController;
13+
import org.elasticsearch.rest.RestRequest;
14+
import org.elasticsearch.rest.RestStatus;
1215
import org.nlpcn.es4sql.SearchDao;
1316
import org.nlpcn.es4sql.exception.SqlParseException;
1417
import org.nlpcn.es4sql.query.QueryAction;
1518

1619
import java.io.IOException;
1720
import java.sql.SQLFeatureNotSupportedException;
18-
import java.util.*;
21+
import java.util.Arrays;
22+
import java.util.HashMap;
23+
import java.util.HashSet;
24+
import java.util.Map;
25+
import java.util.Set;
1926

2027

2128
public class RestSqlAction extends BaseRestHandler {
2229

2330
private static final Logger LOGGER = LogManager.getLogger();
2431

25-
public RestSqlAction(Settings settings, RestController restController) {
26-
super(settings);
27-
restController.registerHandler(RestRequest.Method.POST, "/_sql/_explain", this);
28-
restController.registerHandler(RestRequest.Method.GET, "/_sql/_explain", this);
29-
restController.registerHandler(RestRequest.Method.POST, "/_sql", this);
30-
restController.registerHandler(RestRequest.Method.GET, "/_sql", this);
31-
}
32+
public RestSqlAction(RestController restController) {
33+
restController.registerHandler(RestRequest.Method.POST, "/_sql/_explain", this);
34+
restController.registerHandler(RestRequest.Method.GET, "/_sql/_explain", this);
35+
restController.registerHandler(RestRequest.Method.POST, "/_sql", this);
36+
restController.registerHandler(RestRequest.Method.GET, "/_sql", this);
37+
}
3238

3339
@Override
3440
public String getName() {

src/main/java/org/elasticsearch/plugin/nlpcn/SqlPlug.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,21 @@
1717

1818
public class SqlPlug extends Plugin implements ActionPlugin {
1919

20-
public SqlPlug() {
21-
}
20+
public SqlPlug() {
21+
}
2222

2323

24-
public String name() {
25-
return "sql";
26-
}
24+
public String name() {
25+
return "sql";
26+
}
2727

28-
public String description() {
29-
return "Use sql to query elasticsearch.";
30-
}
28+
public String description() {
29+
return "Use sql to query elasticsearch.";
30+
}
3131

3232

33-
@Override
34-
public List<RestHandler> getRestHandlers(Settings settings, RestController restController, ClusterSettings clusterSettings, IndexScopedSettings indexScopedSettings, SettingsFilter settingsFilter, IndexNameExpressionResolver indexNameExpressionResolver, Supplier<DiscoveryNodes> nodesInCluster) {
35-
return Collections.singletonList(new RestSqlAction(settings, restController));
36-
}
33+
@Override
34+
public List<RestHandler> getRestHandlers(Settings settings, RestController restController, ClusterSettings clusterSettings, IndexScopedSettings indexScopedSettings, SettingsFilter settingsFilter, IndexNameExpressionResolver indexNameExpressionResolver, Supplier<DiscoveryNodes> nodesInCluster) {
35+
return Collections.singletonList(new RestSqlAction(restController));
36+
}
3737
}

src/test/resources/expectedOutput/search_spatial_explain.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
"place" : {
1313
"shape" : {
1414
"type" : "polygon",
15-
"orientation" : "right",
1615
"coordinates" : [
1716
[
1817
[

0 commit comments

Comments
 (0)