style: sort feedback from sonarcloud analysis

Author: georgeRobertson

src/dve/core_engine/backends/implementations/duckdb/contract.py

@@ -175,7 +175,7 @@ def apply_data_contract(
 
                 self.logger.info(f"Data contract found {msg_count} issues in {entity_name}")
 
-                if not RECORD_INDEX_COLUMN_NAME in relation.columns:
+                if RECORD_INDEX_COLUMN_NAME not in relation.columns:
                     relation = self.add_record_index(relation)
 
                 casting_statements = [

src/dve/core_engine/backends/implementations/duckdb/readers/csv.py

@@ -176,7 +176,7 @@ def read_to_relation(  # pylint: disable=unused-argument
             pl_exprs = [
                 pl.col(c).str.strip_chars().replace("", None)
                 for c in df.columns
-                if not c == RECORD_INDEX_COLUMN_NAME
+                if c != RECORD_INDEX_COLUMN_NAME
             ] + [pl.col(RECORD_INDEX_COLUMN_NAME)]
             df = df.select(pl_exprs)
 

src/dve/core_engine/backends/implementations/spark/contract.py

@@ -111,7 +111,7 @@ def apply_data_contract(
                     [], schema=spark_schema
                 )
                 continue
-            if not RECORD_INDEX_COLUMN_NAME in record_df.columns:
+            if RECORD_INDEX_COLUMN_NAME not in record_df.columns:
                 record_df = self.add_record_index(record_df)
 
             if self.debug:

src/dve/core_engine/backends/implementations/spark/spark_helpers.py

@@ -429,7 +429,7 @@ def _add_spark_record_index(self, entity: DataFrame) -> DataFrame:  # pylint: di
 
 def _drop_spark_record_index(self, entity: DataFrame) -> DataFrame:  # pylint: disable=W0613
     """Drop record index from spark dataframe"""
-    if not RECORD_INDEX_COLUMN_NAME in entity.columns:
+    if RECORD_INDEX_COLUMN_NAME not in entity.columns:
         return entity
     return entity.drop(RECORD_INDEX_COLUMN_NAME)
 

src/dve/core_engine/backends/utilities.py

@@ -187,7 +187,7 @@ def _add_polars_record_index(self, entity: pl.LazyFrame) -> pl.LazyFrame:  # pyl
 
 def _drop_polars_record_index(self, entity: pl.LazyFrame) -> pl.LazyFrame:  # pylint: disable=W0613
     """Drop record index from polars dataframe"""
-    if not RECORD_INDEX_COLUMN_NAME in entity.columns:
+    if RECORD_INDEX_COLUMN_NAME not in entity.columns:
         return entity
     return entity.drop(RECORD_INDEX_COLUMN_NAME)