Skip to content

Commit 8ff8ee5

Browse files
committed
Updated .nuspec file and fixed build script
1 parent 35d6f2a commit 8ff8ee5

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ git submodule update
5454
To build the project locally on a Windows Machine:
5555

5656
- Install [Chocolatey](https://chocolatey.org/).
57+
- Optional: update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages).
5758
- Open a Powershell console in Administrative mode and run the build script `build.ps1` in the root of the repository.
5859

5960
## How to contribute
@@ -96,6 +97,10 @@ You can leave all values as default. Now your repository is GitFlow enabled.
9697

9798
### Note on Nuget version on Nuspec
9899

100+
Remember to update `.\src\.nuget\NEventStore.Persistence.Sql.nuspec` file if needed (before creating relase packages).
101+
102+
The .nuspec file is needed because the new `dotnet pack` command has problems dealing with ProjectReferences, submodules get the wrong version number.
103+
99104
While we are on develop branch, (suppose we just bumped major number so the driver version number is 6.0.0-unstablexxxx), we need to declare that this persistence driver depends from a version greater than the latest published. If the latest version of NEventStore 5.x.x wave iw 5.4.0 we need to declare this package dependency as
100105

101106
(5.4, 7)

build.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
$configurationdefault = "Release"
22
$artifacts = "../../artifacts"
3-
$nugetartifacts = "artifacts"
43

54
$configuration = Read-Host 'Configuration to build [default: Release] ?'
65
if ($configuration -eq '') {
@@ -48,4 +47,4 @@ Write-Host "NuGet Packages creation"
4847
#dotnet pack ./src/NEventStore.Persistence.Sql/NEventStore.Persistence.Sql.Core.csproj --no-build -c $configuration -o $artifacts -p:NuspecFile="" -p:NuspecProperties="pippo=$configuration;version=$nugetversion"
4948

5049
#Write-Host nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration"
51-
nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $nugetartifacts
50+
nuget pack ./src/.nuget/NEventStore.Persistence.Sql.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $artifacts

src/.nuget/NEventStore.Persistence.Sql.nuspec

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,24 @@
2121
-->
2222
<dependencies>
2323
<group targetFramework=".NETFramework4.6.1">
24-
<dependency id="NEventStore" version="[8.0.0,9.0.0)" exclude="Build,Analyzers"/>
25-
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
26-
<dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
24+
<dependency id="NEventStore" version="[9.0.0,10.0.0)" exclude="Build,Analyzers"/>
25+
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
26+
<dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
27+
</group>
28+
<group targetFramework="net6.0">
29+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
30+
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
31+
<dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
2732
</group>
2833
<group targetFramework="net5.0">
29-
<dependency id="NEventStore" version="[8.0.0, 9.0.0)" exclude="Build,Analyzers" />
30-
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
31-
<dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
34+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
35+
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
36+
<dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
3237
</group>
3338
<group targetFramework=".NETStandard2.0">
34-
<dependency id="NEventStore" version="[8.0.0,9.0.0)" exclude="Build,Analyzers"/>
35-
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="5.0.0" exclude="Build,Analyzers" />
36-
<dependency id="System.Data.SqlClient" version="4.8.2" exclude="Build,Analyzers" />
39+
<dependency id="NEventStore" version="[9.0.0,10.0.0)" exclude="Build,Analyzers"/>
40+
<dependency id="Microsoft.Extensions.Logging.Abstractions" version="6.0.0" exclude="Build,Analyzers" />
41+
<dependency id="System.Data.SqlClient" version="4.8.3" exclude="Build,Analyzers" />
3742
</group>
3843
</dependencies>
3944
<frameworkAssemblies>

0 commit comments

Comments
 (0)