Refs: #40 Replace System.Data.SqlClient with Microsoft.Data.SqlClient

This commit includes a significant change where the `System.Data.SqlClient` package has been replaced with `Microsoft.Data.SqlClient` across multiple files. This is a breaking change and is highlighted in the `Changelog.md` file. The `Microsoft.Data.SqlClient` package is the latest and recommended data provider for SQL Server.

The connection string for `NEventStore.MsSql` in the `README.md` file has been updated. The `.editorconfig` file now includes new rules for code formatting and style. The `NEventStore.Persistence.Sql.nuspec` file and several project files have been updated to replace the `System.Data.SqlClient` dependency with `Microsoft.Data.SqlClient`.

Several test files have been updated to use `Microsoft.Data.SqlClient` and their code formatting has been updated. The `using System.Data.SqlClient;` and `using Microsoft.Data.SqlClient;` statements have been removed from the `MsSqlDialect.cs` file, and the `using System;` statement has been added.

The `#if NET462` preprocessor directive and its associated code have been removed. The `SqlException` class from the `System.Data.SqlClient` namespace has been replaced with the `SqlException` class from the `Microsoft.Data.SqlClient` namespace in the `IsDuplicate` method.

Lastly, the `MsSqlDialect` and `MsSql2005Dialect` classes have been restructured but their functionality remains the same.

Author: AGiorgetti

Changelog.md

@@ -1,5 +1,14 @@
 # NEventStore.Persistence.Sql
 
+## vNext
+
+- Using Microsoft.Data.SqlClient instead of System.Data.SqlClient [#40](https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/40)
+
+### Breaking Change
+
+- System.Data.SqlClient is not supported anymore.
+- To properly update to Microsoft.Data.SqlClient follow the guirelines in [SqlClient porting cheat sheet](https://github.com/dotnet/SqlClient/blob/main/porting-cheat-sheet.md).
+
 ## 9.1.2
 
 - fixed .nuspec file (wrong net462 references)

README.md

@@ -60,7 +60,7 @@ To build the project locally on a Windows Machine:
 - Define the following environment variables:
 
   ```
-  NEventStore.MsSql="Server=localhost,50001;Database=NEventStore;User Id=sa;Password=Password1;"
+  NEventStore.MsSql="Server=localhost,50001;Database=NEventStore;User Id=sa;Password=Password1;TrustServerCertificate=True;"
   NEventStore.MySql="Server=localhost;Port=50003;Database=NEventStore;Uid=sa;Pwd=Password1;AutoEnlist=false;"
   NEventStore.PostgreSql="Server=localhost;Port=50004;Database=NEventStore;Uid=sa;Pwd=Password1;Enlist=false;"
   NEventStore.Oracle="Data Source=localhost:1521/XE;User Id=system;Password=Password1;Persist Security Info=True;"

src/.editorconfig

@@ -1,7 +1,28 @@
-[*]
+[*]
+
 end_of_line = crlf
-indent_style = space
-indent_size = 4
+indent_style = tab
+trim_trailing_whitespace = true
 
 [*.xml]
-indent_style = space
+
+indent_style = tab
+
+[*.cs]
+
+csharp_new_line_before_open_brace = all
+
+# RCS1229: Use async/await when necessary.
+dotnet_diagnostic.RCS1229.severity = error
+
+# IDE0063: Use simple 'using' statement
+csharp_prefer_simple_using_statement = false
+
+# IDE0090: Use 'new(...)'
+csharp_style_implicit_object_creation_when_type_is_apparent = false
+
+# IDE0290: Use primary constructor
+csharp_style_prefer_primary_constructors = false
+
+# IDE0028: Simplify collection initialization
+dotnet_style_collection_initializer = false

src/.nuget/NEventStore.Persistence.Sql.nuspec

@@ -23,12 +23,12 @@
       <group targetFramework=".NETFramework4.6.2">
         <dependency id="NEventStore" version="[9.1.1,10.0.0)" exclude="Build,Analyzers"/>
         <dependency id="Microsoft.Extensions.Logging.Abstractions" version="7.0.1" exclude="Build,Analyzers" />
-        <dependency id="System.Data.SqlClient" version="4.8.5" exclude="Build,Analyzers" />
+        <dependency id="Microsoft.Data.SqlClient" version="5.2.0" exclude="Build,Analyzers" />
       </group>
       <group targetFramework=".NETStandard2.0">
         <dependency id="NEventStore" version="[9.1.1,10.0.0)" exclude="Build,Analyzers"/>
         <dependency id="Microsoft.Extensions.Logging.Abstractions" version="7.0.1" exclude="Build,Analyzers" />
-        <dependency id="System.Data.SqlClient" version="4.8.5" exclude="Build,Analyzers" />
+        <dependency id="Microsoft.Data.SqlClient" version="5.2.0" exclude="Build,Analyzers" />
       </group>
     </dependencies>
     <frameworkAssemblies>

src/NEventStore.Persistence.MsSql.Tests/NEventStore.Persistence.MsSql.Core.Tests.csproj

@@ -17,7 +17,6 @@
     <PackageReference Include="Microsoft.Data.SqlClient" Version="5.2.0" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'net462'">
-    <PackageReference Include="System.Data.SqlClient" Version="4.8.6" />
     <Reference Include="System.Transactions" />
   </ItemGroup>
   <ItemGroup>

src/NEventStore.Persistence.MsSql.Tests/PersistenceEngineFixture.cs

@@ -2,43 +2,28 @@
 
 namespace NEventStore.Persistence.AcceptanceTests
 {
-    using NEventStore.Persistence.Sql;
-    using NEventStore.Persistence.Sql.SqlDialects;
-    using NEventStore.Serialization;
-#if NET462
-    using System.Data.SqlClient;
-#else
-    using Microsoft.Data.SqlClient;
-#endif
-    using System.Transactions;
+	using NEventStore.Persistence.Sql;
+	using NEventStore.Persistence.Sql.SqlDialects;
+	using NEventStore.Serialization;
+	using System.Transactions;
 
-    public partial class PersistenceEngineFixture
-    {
-        /// <summary>
-        /// this mimic the current NEventStore default values which is run outside any transaction (creates a scope that
-        /// suppresses any transaction)
-        /// </summary>
-        public TransactionScopeOption? ScopeOption { get; set; } = null; // the old default: TransactionScopeOption.Suppress;
+	public partial class PersistenceEngineFixture
+	{
+		/// <summary>
+		/// this mimic the current NEventStore default values which is run outside any transaction (creates a scope that
+		/// suppresses any transaction)
+		/// </summary>
+		public TransactionScopeOption? ScopeOption { get; set; } = null; // the old default: TransactionScopeOption.Suppress;
 
-        public PersistenceEngineFixture()
-        {
-#if NET462
-            _createPersistence = pageSize =>
-                new SqlPersistenceFactory(new EnviromentConnectionFactory("MsSql", "System.Data.SqlClient"),
-                    new BinarySerializer(),
-                    new MsSqlDialect(),
-                    pageSize: pageSize,
-                    scopeOption: ScopeOption
-                    ).Build();
-#else
-            _createPersistence = pageSize =>
-                new SqlPersistenceFactory(new EnviromentConnectionFactory("MsSql", SqlClientFactory.Instance),
-                    new BinarySerializer(),
-                    new MsSqlDialect(),
-                    pageSize: pageSize,
-                    scopeOption: ScopeOption
-                    ).Build();
-#endif
-        }
-    }
+		public PersistenceEngineFixture()
+		{
+			_createPersistence = pageSize =>
+				new SqlPersistenceFactory(new EnviromentConnectionFactory("MsSql", Microsoft.Data.SqlClient.SqlClientFactory.Instance),
+					new BinarySerializer(),
+					new MsSqlDialect(),
+					pageSize: pageSize,
+					scopeOption: ScopeOption
+					).Build();
+		}
+	}
 }