Merge pull request #59 from NETWAYS/chore/go1-23

Bump to Go 1.23

Author: martialblog

.github/workflows/build.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21
+          go-version: 1.23
 
       - name: Test
         run: go test -v ./...

.github/workflows/golangci-lint.yml

@@ -17,4 +17,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54
+          version: v1.61

.golangci.yml

@@ -22,6 +22,7 @@ linters:
      - goerr113
      - gofumpt
      - gomnd
+     - mnd
      - lll
      - musttag
      - nakedret

cmd/config.go

@@ -104,6 +104,7 @@ func (c *Config) NewClient() *client.Client {
 	// Using a BasicAuth for authentication
 	if c.Username != "" {
 		if c.Password == "" {
+			// nolint: perfsprint
 			check.ExitError(fmt.Errorf("specify the user name and password for server authentication"))
 		}
 

cmd/health.go

@@ -17,7 +17,7 @@ The cluster health status is:
 	red = CRITICAL`,
 	Example: "  check_elasticsearch health --hostname \"127.0.0.1\" --port 9200 --username \"exampleUser\"  " +
 		"--password \"examplePass\" --tls --insecure",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		client := cliConfig.NewClient()
 
 		health, err := client.Health()

cmd/ingest.go

@@ -23,7 +23,7 @@ var ingestCmd = &cobra.Command{
 	Use:   "ingest",
 	Short: "Checks the ingest statistics of Ingest Pipelines",
 	Long:  `Checks the ingest statistics of Ingest Pipelines`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		var (
 			rc       int
 			output   string

cmd/query.go

@@ -32,7 +32,7 @@ For more information to the syntax, please visit:
 https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html`,
 	Example: "check_elasticsearch query -q \"event.dataset:sample_web_logs and @timestamp:[now-5m TO now]\" " +
 		"-I \"kibana_sample_data_logs\" -k \"message\"",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		var (
 			rc     int
 			output strings.Builder

cmd/root.go

@@ -14,7 +14,7 @@ var (
 var rootCmd = &cobra.Command{
 	Use:   "check_elasticsearch",
 	Short: "Icinga check plugin to check Elasticsearch",
-	PersistentPreRun: func(cmd *cobra.Command, args []string) {
+	PersistentPreRun: func(_ *cobra.Command, _ []string) {
 		go check.HandleTimeout(timeout)
 	},
 	Run: Help,

cmd/snapshot.go

@@ -32,7 +32,7 @@ $ check_elasticsearch snapshot --all
 $ check_elasticsearch snapshot --number 5
 [WARNING] - At least one evaluated snapshot is in state PARTIAL
 `,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		repository, _ := cmd.Flags().GetString("repository")
 		snapshot, _ := cmd.Flags().GetString("snapshot")
 		numberOfSnapshots, _ := cmd.Flags().GetInt("number")