-
Notifications
You must be signed in to change notification settings - Fork 2
Administrate improvement and updates #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
A-Wheeto
wants to merge
10
commits into
main
Choose a base branch
from
2739-programme-overview-in-administrate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f16b6bc
Adding back button to the email reports dashboards
A-Wheeto e23db83
Updating administrate routes, making dashboard alphabetical and remov…
A-Wheeto 8b71b9b
First pass at programme dashboard
A-Wheeto 9b55354
Removing hub and hub region dashboard, controller and tests
A-Wheeto 3c971fe
Programme dashboard for each programme with an overview of programme …
A-Wheeto 6af208c
Adding test for programmes on index
A-Wheeto 4100fe4
Add back button
A-Wheeto 52732d8
Updated from count to size for optimization
A-Wheeto 1d9c49c
Adding stem activity code into activity views
A-Wheeto 237e6e5
Minor updates to test inline with changes
A-Wheeto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module Admin | ||
class ProgrammesController < Admin::ApplicationController | ||
def index | ||
@programmes = [ | ||
Programme.cs_accelerator, | ||
Programme.primary_certificate, | ||
Programme.secondary_certificate, | ||
Programme.i_belong, | ||
Programme.a_level | ||
].compact.sort_by(&:title) | ||
end | ||
|
||
def show | ||
@programme = Programme.includes( | ||
programme_activity_groupings: :activities, | ||
pathways: {pathway_activities: :activity} | ||
).find(params[:id]) | ||
end | ||
end | ||
end |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<header class="main-content__header"> | ||
<h1 class="main-content__page-title"> | ||
Programmes | ||
</h1> | ||
</header> | ||
|
||
<section class="main-content__body"> | ||
<ul> | ||
<% @programmes.each do |programme| %> | ||
<li><%= link_to programme.title, admin_programme_path(programme.id) %></li> | ||
<% end %> | ||
</ul> | ||
</section> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raised an eyebrow at first, but I then realised this is just 5 records being sorted in memory, not 5 sets of records.