Administrate improvement and updates #2436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing hubs and hub regions as they are not currently used on teach computing after April 1st 2025.
…activity groupings, pathways and assessments - if any Minor improvements to the reports dashboard
A-Wheeto
force-pushed
the
2739-programme-overview-in-administrate
branch
from
a118f38 to
4100fe4
Compare
barrywoolgar
approved these changes
Jul 15, 2025
| <% @programme.pathways.each do |pathway| %> | ||
| <tr> | ||
| <td><%= pathway.title %></td> | ||
| <td><%= pathway.pathway_activities.count %></td> |
There was a problem hiding this comment.
Using .count on an association you've eager loaded will be triggering an extra SQL query unnecessarily. In Rails it's best to prefer .size over .count as the former will first check if the collection has already been loaded into memory, and count that instead.
There was a problem hiding this comment.
Good tip, I'll update this to .size, thanks Barry!
Comment on lines
+4
to
+10
| @programmes = [ | ||
| Programme.cs_accelerator, | ||
| Programme.primary_certificate, | ||
| Programme.secondary_certificate, | ||
| Programme.i_belong, | ||
| Programme.a_level | ||
| ].compact.sort_by(&:title) |
There was a problem hiding this comment.
This raised an eyebrow at first, but I then realised this is just 5 records being sorted in memory, not 5 sets of records.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.