Skip to content
This repository was archived by the owner on Jan 4, 2021. It is now read-only.

Commit a75db88

Browse files
committed
[DEV] Fix Makefile new task
1 parent cad392b commit a75db88

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+504
-601
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
bower_components
2+
node_modules
23
*~
34
*#
45
*.idea

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@ dev:
1818
@polyserve
1919

2020
docs:
21-
rm -rf docs/components/* && mkdir -p docs/components; cd docs && bower install -q ../../myscript-text-web; cp -r bower_components/* docs/components/
21+
@rm -rf docs/components/* && mkdir -p docs/components
22+
@cd docs && bower install -q ../../myscript-text-web
23+
@cp -r bower_components/* docs/components/

docs/components/iron-icon/.bower.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@
3232
"web-component-tester": "^4.0.0",
3333
"webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0"
3434
},
35-
"homepage": "https://github.com/polymerelements/iron-icon",
35+
"homepage": "https://github.com/PolymerElements/iron-icon",
3636
"_release": "1.0.12",
3737
"_resolution": {
3838
"type": "version",
3939
"tag": "v1.0.12",
4040
"commit": "e6bce09a074f9f8433f168081405b7e44d525c62"
4141
},
42-
"_source": "https://github.com/polymerelements/iron-icon.git",
42+
"_source": "https://github.com/PolymerElements/iron-icon.git",
4343
"_target": "^1.0.0",
44-
"_originalSource": "polymerelements/iron-icon"
44+
"_originalSource": "PolymerElements/iron-icon"
4545
}

docs/components/iron-icons/.bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@
4242
"commit": "3752efe4bb6c248b9dfeefb73f0d1ce6d446dff7"
4343
},
4444
"_source": "https://github.com/PolymerElements/iron-icons.git",
45-
"_target": "^1.0.0",
45+
"_target": "1.2.x",
4646
"_originalSource": "PolymerElements/iron-icons"
4747
}

docs/components/iron-overlay-behavior/.bower.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "iron-overlay-behavior",
3-
"version": "1.10.2",
3+
"version": "1.10.3",
44
"license": "http://polymer.github.io/LICENSE.txt",
55
"description": "Provides a behavior for making an element an overlay",
66
"private": true,
@@ -35,11 +35,11 @@
3535
},
3636
"ignore": [],
3737
"homepage": "https://github.com/PolymerElements/iron-overlay-behavior",
38-
"_release": "1.10.2",
38+
"_release": "1.10.3",
3939
"_resolution": {
4040
"type": "version",
41-
"tag": "v1.10.2",
42-
"commit": "27558b9ceeba7c670999818fc50eebe7e044ed5c"
41+
"tag": "v1.10.3",
42+
"commit": "3aee4eea429e6a0e0e4700d5508b35f71d985548"
4343
},
4444
"_source": "https://github.com/PolymerElements/iron-overlay-behavior.git",
4545
"_target": "^1.0.9",

docs/components/iron-overlay-behavior/bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "iron-overlay-behavior",
3-
"version": "1.10.2",
3+
"version": "1.10.3",
44
"license": "http://polymer.github.io/LICENSE.txt",
55
"description": "Provides a behavior for making an element an overlay",
66
"private": true,

docs/components/iron-overlay-behavior/iron-overlay-manager.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,11 @@
4040
this._backdropElement = null;
4141

4242
// Enable document-wide tap recognizer.
43-
Polymer.Gestures.add(document, 'tap', this._onCaptureClick.bind(this));
44-
43+
// NOTE: Use useCapture=true to avoid accidentally prevention of the closing
44+
// of an overlay via event.stopPropagation(). The only way to prevent
45+
// closing of an overlay should be through its APIs.
46+
Polymer.Gestures.add(document, 'tap', null);
47+
document.addEventListener('tap', this._onCaptureClick.bind(this), true);
4548
document.addEventListener('focus', this._onCaptureFocus.bind(this), true);
4649
document.addEventListener('keydown', this._onCaptureKeyDown.bind(this), true);
4750
};

docs/components/iron-overlay-behavior/test/iron-overlay-behavior.html

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,38 @@ <h2>Focusables (with tabindex)</h2>
428428
});
429429
});
430430

431+
suite('tap event listener', function() {
432+
var overlay;
433+
434+
var preventTap = function(event) {
435+
event.preventDefault();
436+
event.stopPropagation();
437+
};
438+
439+
suiteSetup(function() {
440+
// Worst case scenario: listener with useCapture = true that prevents & stops propagation
441+
// added before the overlay is initialized.
442+
document.body.addEventListener('tap', preventTap, true);
443+
});
444+
445+
setup(function() {
446+
overlay = fixture('basic');
447+
});
448+
449+
suiteTeardown(function() {
450+
document.body.removeEventListener('tap', preventTap, true);
451+
});
452+
453+
test('cancel an overlay with tap outside even if event is prevented by other listeners', function(done) {
454+
runAfterOpen(overlay, function() {
455+
overlay.addEventListener('iron-overlay-canceled', function(event) {
456+
done();
457+
});
458+
MockInteractions.tap(document.body);
459+
});
460+
});
461+
});
462+
431463
suite('opened overlay', function() {
432464
var overlay;
433465

docs/components/iron-overlay-behavior/test/test-buttons-wrapper.html

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@
1212
<link rel="import" href="test-buttons.html">
1313

1414
<dom-module id="test-buttons-wrapper">
15-
16-
<style>
17-
:host {
18-
display: block;
19-
border: 1px solid gray;
20-
padding: 10px;
21-
}
22-
</style>
23-
2415
<template>
16+
<style>
17+
:host {
18+
display: block;
19+
border: 1px solid gray;
20+
padding: 10px;
21+
}
22+
</style>
23+
2524
<select id="select">
2625
<option>1</option>
2726
</select>

docs/components/myscript-common-element/.bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@
3333
"resolutions": {
3434
"polymer": "1.8.x"
3535
},
36-
"_release": "6b4c17dcff",
36+
"_release": "46c0ab5bd9",
3737
"_resolution": {
3838
"type": "branch",
3939
"branch": "2.0.0-alpha1",
40-
"commit": "6b4c17dcff94023e0c5f3fff5d18f6725509bf6b"
40+
"commit": "46c0ab5bd9162ece39420c22c27a53c4eee6cc55"
4141
},
4242
"_source": "https://scm.corp.myscript.com/scm/ws/webcomponents-myscript-common-element.git",
4343
"_target": "2.0.0-alpha1",

0 commit comments

Comments
 (0)