Skip to content
This repository was archived by the owner on Jan 4, 2021. It is now read-only.

Commit 07ae57d

Browse files
committed
[FIX] Pointer events for Firefox
1 parent 2d79134 commit 07ae57d

13 files changed

+3469
-3197
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# [v4.1.2](https://github.com/MyScript/MyScriptJS/tree/v4.1.2)
2+
3+
## Bug fixed
4+
5+
- Pointer move was not detected on new Firefox 59 due to support for pointer events
6+
17
# [v4.1.1](https://github.com/MyScript/MyScriptJS/tree/v4.1.1)
28

39
## Features

dist/myscript.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/myscript.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/ast/source/grabber/PointerEventGrabber.js.json

+3,420-3,161
Large diffs are not rendered by default.

docs/dump.json

+1-1
Large diffs are not rendered by default.

docs/file/src/grabber/PointerEventGrabber.js.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@
358358

359359
function pointerDownHandler(evt) { // Trigger a pointerDown
360360
const pointerDownOnEditor = evt.target.id === editor.domElement.id || evt.target.classList.contains('ms-canvas');
361-
if (this.activePointerId) {
361+
if (this.activePointerId !== undefined) {
362362
if (this.activePointerId === evt.pointerId) {
363363
logger.trace(`${evt.type} event with the same id without any pointer up`, evt.pointerId);
364364
}
@@ -384,7 +384,7 @@
384384

385385
function pointerMoveHandler(evt) { // Trigger a pointerMove
386386
// Only considering the active pointer
387-
if (this.activePointerId && this.activePointerId === evt.pointerId) {
387+
if (this.activePointerId !== undefined && this.activePointerId === evt.pointerId) {
388388
unfocus();
389389
editor.pointerMove(extractPoint(evt, element, editor.configuration, offsetTop, offsetLeft));
390390
} else if (this.smartGuidePointerDown) {
@@ -419,7 +419,7 @@
419419
const pointerMovedWords = evt.relatedTarget && evt.target && (evt.target.tagName === 'SPAN' || evt.relatedTarget.tagName === 'SPAN');
420420
if (pointerEnteredSmartGuide || pointerExitedSmartGuide || pointerMovedWords) {
421421
evt.stopPropagation();
422-
} else if (this.activePointerId && this.activePointerId === evt.pointerId) { // Only considering the active pointer
422+
} else if (this.activePointerId !== undefined && this.activePointerId === evt.pointerId) { // Only considering the active pointer
423423
this.activePointerId = undefined; // Managing the active pointer
424424
evt.stopPropagation();
425425
editor.pointerUp(extractPoint(evt, element, editor.configuration, offsetTop, offsetLeft));

docs/manual/changelog/CHANGELOG.html

+9-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@
4444
<div data-ice="manual" data-toc-name="changelog">
4545
<ul class="manual-toc">
4646

47-
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-" data-ice="link">v4.1.1</a></li>
47+
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-2-https-github-com-myscript-myscriptjs-tree-v4-1-2-" data-ice="link">v4.1.2</a></li>
48+
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#bug-fixed" data-ice="link">Bug fixed</a></li>
49+
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-" data-ice="link">v4.1.1</a></li>
4850
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#features" data-ice="link">Features</a></li>
4951
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#bugs-fixed" data-ice="link">Bugs fixed</a></li>
5052
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#breaking-changes" data-ice="link">Breaking changes</a></li>
@@ -70,7 +72,12 @@
7072
<span>&#xBB;</span>
7173
<span data-ice="title">Changelog</span>
7274
</div>
73-
<div data-ice="content"><h1 id="-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-"><a href="https://github.com/MyScript/MyScriptJS/tree/v4.1.1">v4.1.1</a></h1>
75+
<div data-ice="content"><h1 id="-v4-1-2-https-github-com-myscript-myscriptjs-tree-v4-1-2-"><a href="https://github.com/MyScript/MyScriptJS/tree/v4.1.2">v4.1.2</a></h1>
76+
<h2 id="bug-fixed">Bug fixed</h2>
77+
<ul>
78+
<li>Pointer move was not detected on new Firefox 59 due to support for pointer events</li>
79+
</ul>
80+
<h1 id="-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-"><a href="https://github.com/MyScript/MyScriptJS/tree/v4.1.1">v4.1.1</a></h1>
7481
<h2 id="features">Features</h2>
7582
<ul>
7683
<li>New export in <code>myscript.js</code> for better import using frameworks (as React).</li>

docs/manual/index.html

+3-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@
4444
<div data-ice="manual" data-toc-name="changelog">
4545
<ul class="manual-toc">
4646

47-
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-" data-ice="link">v4.1.1</a></li>
47+
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-2-https-github-com-myscript-myscriptjs-tree-v4-1-2-" data-ice="link">v4.1.2</a></li>
48+
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#bug-fixed" data-ice="link">Bug fixed</a></li>
49+
<li data-ice="manualNav" class="indent-h1 manual-color manual-color-changelog" data-section-count="&#x25A0;&#x25A0;&#x25A0;&#x25A0;" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#-v4-1-1-https-github-com-myscript-myscriptjs-tree-v4-1-1-" data-ice="link">v4.1.1</a></li>
4850
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#features" data-ice="link">Features</a></li>
4951
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#bugs-fixed" data-ice="link">Bugs fixed</a></li>
5052
<li data-ice="manualNav" class="indent-h2" data-link="manual/changelog/CHANGELOG.html"><a href="manual/changelog/CHANGELOG.html#breaking-changes" data-ice="link">Breaking changes</a></li>

docs/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"window-mock": "^0.0.13"
7474
},
7575
"scripts": {
76-
"install": "bower install",
7776
"build": "gulp",
7877
"test": "gulp test",
7978
"start": "gulp serve"

docs/source.html

+20-20
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@
282282
<td class="coverage"><span data-ice="coverage">89 %</span><span data-ice="coverageCount" class="coverage-count">53/59</span></td>
283283
<td style="display: none;" data-ice="size">29045 byte</td>
284284
<td style="display: none;" data-ice="lines">970</td>
285-
<td style="display: none;" data-ice="updated">2018-02-06 14:42:38 (UTC)</td>
285+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
286286
</tr>
287287
<tr data-ice="file">
288288
<td data-ice="filePath"><span><a href="file/src/EditorFacade.js.html">src/EditorFacade.js</a></span></td>
@@ -291,7 +291,7 @@
291291
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">2/2</span></td>
292292
<td style="display: none;" data-ice="size">1313 byte</td>
293293
<td style="display: none;" data-ice="lines">29</td>
294-
<td style="display: none;" data-ice="updated">2018-02-02 09:50:32 (UTC)</td>
294+
<td style="display: none;" data-ice="updated">2018-03-02 10:26:39 (UTC)</td>
295295
</tr>
296296
<tr data-ice="file">
297297
<td data-ice="filePath"><span><a href="file/src/callback/EventCallback.js.html">src/callback/EventCallback.js</a></span></td>
@@ -316,7 +316,7 @@
316316
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">2/2</span></td>
317317
<td style="display: none;" data-ice="size">4741 byte</td>
318318
<td style="display: none;" data-ice="lines">85</td>
319-
<td style="display: none;" data-ice="updated">2018-01-04 15:19:11 (UTC)</td>
319+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
320320
</tr>
321321
<tr data-ice="file">
322322
<td data-ice="filePath"><span><a href="file/src/configuration/DefaultConfiguration.js.html">src/configuration/DefaultConfiguration.js</a></span></td>
@@ -325,7 +325,7 @@
325325
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">2/2</span></td>
326326
<td style="display: none;" data-ice="size">4778 byte</td>
327327
<td style="display: none;" data-ice="lines">177</td>
328-
<td style="display: none;" data-ice="updated">2018-02-02 09:51:38 (UTC)</td>
328+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
329329
</tr>
330330
<tr data-ice="file">
331331
<td data-ice="filePath"><span><a href="file/src/configuration/DefaultPenStyle.js.html#errorLines=31,36">src/configuration/DefaultPenStyle.js</a></span></td>
@@ -379,9 +379,9 @@
379379
<td data-ice="identifier" class="identifiers"><span><a href="function/index.html#static-function-attach">attach</a></span>
380380
<span><a href="function/index.html#static-function-detach">detach</a></span></td>
381381
<td class="coverage"><span data-ice="coverage">50 %</span><span data-ice="coverageCount" class="coverage-count">1/2</span></td>
382-
<td style="display: none;" data-ice="size">8840 byte</td>
382+
<td style="display: none;" data-ice="size">8882 byte</td>
383383
<td style="display: none;" data-ice="lines">193</td>
384-
<td style="display: none;" data-ice="updated">2018-02-02 09:51:38 (UTC)</td>
384+
<td style="display: none;" data-ice="updated">2018-03-03 14:41:52 (UTC)</td>
385385
</tr>
386386
<tr data-ice="file">
387387
<td data-ice="filePath"><span><a href="file/src/model/InkModel.js.html">src/model/InkModel.js</a></span></td>
@@ -406,7 +406,7 @@
406406
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">18/18</span></td>
407407
<td style="display: none;" data-ice="size">11842 byte</td>
408408
<td style="display: none;" data-ice="lines">326</td>
409-
<td style="display: none;" data-ice="updated">2018-01-02 09:38:57 (UTC)</td>
409+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
410410
</tr>
411411
<tr data-ice="file">
412412
<td data-ice="filePath"><span><a href="file/src/model/RecognizerContext.js.html">src/model/RecognizerContext.js</a></span></td>
@@ -433,7 +433,7 @@
433433
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">5/5</span></td>
434434
<td style="display: none;" data-ice="size">5177 byte</td>
435435
<td style="display: none;" data-ice="lines">147</td>
436-
<td style="display: none;" data-ice="updated">2018-01-04 15:22:30 (UTC)</td>
436+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
437437
</tr>
438438
<tr data-ice="file">
439439
<td data-ice="filePath"><span><a href="file/src/model/Symbol.js.html">src/model/Symbol.js</a></span></td>
@@ -462,23 +462,23 @@
462462
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">4/4</span></td>
463463
<td style="display: none;" data-ice="size">4263 byte</td>
464464
<td style="display: none;" data-ice="lines">91</td>
465-
<td style="display: none;" data-ice="updated">2017-12-02 16:29:14 (UTC)</td>
465+
<td style="display: none;" data-ice="updated">2018-03-05 15:16:00 (UTC)</td>
466466
</tr>
467467
<tr data-ice="file">
468468
<td data-ice="filePath"><span><a href="file/src/myscript.js.html">src/myscript.js</a></span></td>
469469
<td data-ice="identifier" class="identifiers">-</td>
470470
<td class="coverage"><span data-ice="coverage">-</span></td>
471471
<td style="display: none;" data-ice="size">739 byte</td>
472472
<td style="display: none;" data-ice="lines">31</td>
473-
<td style="display: none;" data-ice="updated">2018-02-02 09:51:38 (UTC)</td>
473+
<td style="display: none;" data-ice="updated">2018-03-03 11:28:58 (UTC)</td>
474474
</tr>
475475
<tr data-ice="file">
476476
<td data-ice="filePath"><span><a href="file/src/recognizer/CryptoHelper.js.html">src/recognizer/CryptoHelper.js</a></span></td>
477477
<td data-ice="identifier" class="identifiers"><span><a href="function/index.html#static-function-computeHmac">computeHmac</a></span></td>
478478
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">1/1</span></td>
479479
<td style="display: none;" data-ice="size">693 byte</td>
480480
<td style="display: none;" data-ice="lines">17</td>
481-
<td style="display: none;" data-ice="updated">2017-09-03 13:17:23 (UTC)</td>
481+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
482482
</tr>
483483
<tr data-ice="file">
484484
<td data-ice="filePath"><span><a href="file/src/recognizer/DefaultRecognizer.js.html">src/recognizer/DefaultRecognizer.js</a></span></td>
@@ -524,7 +524,7 @@
524524
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">1/1</span></td>
525525
<td style="display: none;" data-ice="size">887 byte</td>
526526
<td style="display: none;" data-ice="lines">22</td>
527-
<td style="display: none;" data-ice="updated">2017-09-03 13:17:23 (UTC)</td>
527+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
528528
</tr>
529529
<tr data-ice="file">
530530
<td data-ice="filePath"><span><a href="file/src/recognizer/rest/networkInterface.js.html">src/recognizer/rest/networkInterface.js</a></span></td>
@@ -533,7 +533,7 @@
533533
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">2/2</span></td>
534534
<td style="display: none;" data-ice="size">3168 byte</td>
535535
<td style="display: none;" data-ice="lines">114</td>
536-
<td style="display: none;" data-ice="updated">2017-09-03 13:17:23 (UTC)</td>
536+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
537537
</tr>
538538
<tr data-ice="file">
539539
<td data-ice="filePath"><span><a href="file/src/recognizer/rest/v3/Cdkv3RestAnalyzerRecognizer.js.html">src/recognizer/rest/v3/Cdkv3RestAnalyzerRecognizer.js</a></span></td>
@@ -572,7 +572,7 @@
572572
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">1/1</span></td>
573573
<td style="display: none;" data-ice="size">1438 byte</td>
574574
<td style="display: none;" data-ice="lines">28</td>
575-
<td style="display: none;" data-ice="updated">2017-09-03 13:17:23 (UTC)</td>
575+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
576576
</tr>
577577
<tr data-ice="file">
578578
<td data-ice="filePath"><span><a href="file/src/recognizer/rest/v3/Cdkv3RestShapeRecognizer.js.html">src/recognizer/rest/v3/Cdkv3RestShapeRecognizer.js</a></span></td>
@@ -659,7 +659,7 @@
659659
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">1/1</span></td>
660660
<td style="display: none;" data-ice="size">7355 byte</td>
661661
<td style="display: none;" data-ice="lines">159</td>
662-
<td style="display: none;" data-ice="updated">2018-01-04 15:22:30 (UTC)</td>
662+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
663663
</tr>
664664
<tr data-ice="file">
665665
<td data-ice="filePath"><span><a href="file/src/recognizer/websocket/v4/Cdkv4WSIInkRecognizer.js.html#errorLines=204,211,218,57,68,80,89,98">src/recognizer/websocket/v4/Cdkv4WSIInkRecognizer.js</a></span></td>
@@ -693,7 +693,7 @@
693693
<td class="coverage"><span data-ice="coverage">70 %</span><span data-ice="coverageCount" class="coverage-count">19/27</span></td>
694694
<td style="display: none;" data-ice="size">20030 byte</td>
695695
<td style="display: none;" data-ice="lines">552</td>
696-
<td style="display: none;" data-ice="updated">2018-01-04 15:22:30 (UTC)</td>
696+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
697697
</tr>
698698
<tr data-ice="file">
699699
<td data-ice="filePath"><span><a href="file/src/renderer/QuadraticUtils.js.html">src/renderer/QuadraticUtils.js</a></span></td>
@@ -716,7 +716,7 @@
716716
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">6/6</span></td>
717717
<td style="display: none;" data-ice="size">7362 byte</td>
718718
<td style="display: none;" data-ice="lines">200</td>
719-
<td style="display: none;" data-ice="updated">2017-09-06 08:22:19 (UTC)</td>
719+
<td style="display: none;" data-ice="updated">2018-02-06 09:09:22 (UTC)</td>
720720
</tr>
721721
<tr data-ice="file">
722722
<td data-ice="filePath"><span><a href="file/src/renderer/canvas/ImageRenderer.js.html">src/renderer/canvas/ImageRenderer.js</a></span></td>
@@ -733,7 +733,7 @@
733733
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">2/2</span></td>
734734
<td style="display: none;" data-ice="size">4529 byte</td>
735735
<td style="display: none;" data-ice="lines">107</td>
736-
<td style="display: none;" data-ice="updated">2017-09-03 13:17:23 (UTC)</td>
736+
<td style="display: none;" data-ice="updated">2018-03-05 09:10:03 (UTC)</td>
737737
</tr>
738738
<tr data-ice="file">
739739
<td data-ice="filePath"><span><a href="file/src/renderer/canvas/symbols/MathSymbolCanvasRenderer.js.html">src/renderer/canvas/symbols/MathSymbolCanvasRenderer.js</a></span></td>
@@ -793,7 +793,7 @@
793793
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">6/6</span></td>
794794
<td style="display: none;" data-ice="size">7746 byte</td>
795795
<td style="display: none;" data-ice="lines">211</td>
796-
<td style="display: none;" data-ice="updated">2018-01-04 15:21:35 (UTC)</td>
796+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
797797
</tr>
798798
<tr data-ice="file">
799799
<td data-ice="filePath"><span><a href="file/src/renderer/svg/stroker/QuadraticSVGStroker.js.html">src/renderer/svg/stroker/QuadraticSVGStroker.js</a></span></td>
@@ -821,7 +821,7 @@
821821
<td class="coverage"><span data-ice="coverage">75 %</span><span data-ice="coverageCount" class="coverage-count">3/4</span></td>
822822
<td style="display: none;" data-ice="size">20045 byte</td>
823823
<td style="display: none;" data-ice="lines">503</td>
824-
<td style="display: none;" data-ice="updated">2018-02-02 09:51:38 (UTC)</td>
824+
<td style="display: none;" data-ice="updated">2018-03-03 14:35:08 (UTC)</td>
825825
</tr>
826826
<tr data-ice="file">
827827
<td data-ice="filePath"><span><a href="file/src/util/ModelStats.js.html">src/util/ModelStats.js</a></span></td>

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"window-mock": "^0.0.13"
7474
},
7575
"scripts": {
76-
"install": "bower install",
7776
"build": "gulp",
7877
"test": "gulp test",
7978
"start": "gulp serve"

0 commit comments

Comments
 (0)