Skip to content

[TASK] Make RuleSet concrete #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TASK] Make RuleSet concrete #1341

wants to merge 1 commit into from

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jul 18, 2025

... adding internal render method.

Precursor to #1194.

... adding internal `render` method.

Precursor to #1194.
@coveralls
Copy link

Coverage Status

coverage: 59.794% (+0.04%) from 59.751%
when pulling 6fdb2e3 on task/ruleset-concrete
into 8c4a77e on main.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good.

I'd suggest moving the tests for render() to functional tests, though, as they also test the effects of OutputFormat/OutputFormatter.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Jul 18, 2025

the tests ... also test the effects of OutputFormat/OutputFormatter.

Only insofar as the expected CSS matches that rendered with the default OutputFormat - there aren't any tests for varying the spacing.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Jul 19, 2025

the tests ... also test the effects of OutputFormat/OutputFormatter.

Only insofar as the expected CSS matches that rendered with the default OutputFormat - there aren't any tests for varying the spacing.

I note the equivalent tests for other classes are in the Functional department, and also test with pretty and compact formats. So this should probably test those too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants