Incorrect selector splitting

[fritz-pal]

Selectors like:

#main .button:where(:hover, :focus)
.card :is(.title, p)

incorrectly get split up into 2 selectors.

[sabberworm]

Thanks for the report. It is a known issue (see #360 and #138).

[JakeQZ]

This is the culprit (line number at time of writing): https://github.com/MyIntervals/PHP-CSS-Parser/blob/main/src/RuleSet/DeclarationBlock.php#L84

A quick fix may be for DeclarationBlock::parse() to send a one-element array to setSelectors.

Long-term, I don't think setSelectors should attempt simple splitting by comma - there may be commas in quoted strings. If parse() is able to split the parts up reliably, splitting could be done. But it doesn't do so at present. Also, the selector is a single entity, which may involve a comma separated list, and, even if so, does not mean separate selectors (e.g. when used as argument for :not()).

I think we solve this by deprecating and removing splitting by commas in setSelectors (not tested). @sabberworm, @oliverklee, WDYT?

[oliverklee]

I think we solve this by deprecating and removing splitting by commas in setSelectors (not tested).

Yes, makes sense.

[JakeQZ]

If there are use cases which depend on splitting the top-level selector list at commas, this would need to be done by parse().

[JakeQZ]

If there are use cases which depend on splitting the top-level selector list at commas, this would need to be done by parse().

Indeed there are, e.g. removeSelector() to remove one from the comma-delimited list.

Thus I think parse() needs to handle the brackets and commas, and pass an array to setSelectors().

As a separate change, the splitting by comma in setSelectors() should nonetheless be deprecated and removed, as it also breaks manipulation functionality for these examples.