Merge pull request #167 from raxbg/fix/vm_size_parsing

sabberworm · web-flow · commit c4509f5eae72 · 2019-08-12T13:29:11.000+02:00
Bug fix in parsing size units
diff --git a/lib/Sabberworm/CSS/Value/Size.php b/lib/Sabberworm/CSS/Value/Size.php
@@ -61,8 +61,7 @@ private static function getSizeUnits() {
 				self::$SIZE_UNITS[$iSize][strtolower($val)] = $val;
 			}
 
-			// FIXME: Should we not order the longest units first?
-			ksort(self::$SIZE_UNITS, SORT_NUMERIC);
+			krsort(self::$SIZE_UNITS, SORT_NUMERIC);
 		}
 
 		return self::$SIZE_UNITS;

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,7 @@ private static function getSizeUnits() {`
`61`	`61`	`self::$SIZE_UNITS[$iSize][strtolower($val)] = $val;`
`62`	`62`	`}`
`63`	`63`
`64`		`- // FIXME: Should we not order the longest units first?`
`65`		`- ksort(self::$SIZE_UNITS, SORT_NUMERIC);`
	`64`	`+ krsort(self::$SIZE_UNITS, SORT_NUMERIC);`
`66`	`65`	`}`
`67`	`66`
`68`	`67`	`return self::$SIZE_UNITS;`