Skip to content

Commit 1ade62f

Browse files
committed
[TASK] Deprecate ::atRuleArgs()
These methods - are not used internally - are redundant to the existing getters - have wildly different return types across classes, which reduces the usefulness of the general method
1 parent d11477c commit 1ade62f

File tree

8 files changed

+15
-0
lines changed

8 files changed

+15
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
3030

3131
### Deprecated
3232

33+
- Deprecate `::atRuleArgs()` (#1191)
3334
- Passing a `string` or `null` to `RuleSet::removeRule()` is deprecated
3435
(implementing classes are `AtRuleSet` and `DeclarationBlock`);
3536
use `removeMatchingRules()` or `removeAllRules()` instead (#1249)

src/CSSList/AtRuleBlockList.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ public function atRuleName()
4242

4343
/**
4444
* @return string
45+
*
46+
* @deprecated since V8.9.0, will be removed in version 9.0.0. Use the specific getter instead.
4547
*/
4648
public function atRuleArgs()
4749
{

src/CSSList/KeyFrame.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ public function atRuleName()
101101

102102
/**
103103
* @return string|null
104+
*
105+
* @deprecated since V8.9.0, will be removed in version 9.0.0. Use the specific getter instead.
104106
*/
105107
public function atRuleArgs()
106108
{

src/Property/AtRule.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ public function atRuleName();
3333

3434
/**
3535
* @return string|null
36+
*
37+
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter(s) instead.
3638
*/
3739
public function atRuleArgs();
3840
}

src/Property/CSSNamespace.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ public function atRuleName()
116116

117117
/**
118118
* @return array<int, string>
119+
*
120+
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getters instead.
119121
*/
120122
public function atRuleArgs()
121123
{

src/Property/Charset.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ public function atRuleName()
9999

100100
/**
101101
* @return string
102+
*
103+
* @deprecated since V8.9.0, will be removed in version 9.0.0. Use the specific getter instead.
102104
*/
103105
public function atRuleArgs()
104106
{

src/Property/Import.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ public function atRuleName()
9494

9595
/**
9696
* @return array<int, URL|string>
97+
*
98+
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getters instead.
9799
*/
98100
public function atRuleArgs()
99101
{

src/RuleSet/AtRuleSet.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ public function atRuleName()
4545

4646
/**
4747
* @return string
48+
*
49+
* @deprecated since V8.9.0, will be removed in version 9.0.0. Use the specific getter instead.
4850
*/
4951
public function atRuleArgs()
5052
{

0 commit comments

Comments
 (0)