[BUGFIX] Parse @font-face src property as comma-delimited list (#790)

Fixes #789.

Also adds an initial `TestCase` for `Rule/Rule`.

Author: JakeQZ

CHANGELOG.md

@@ -42,6 +42,7 @@ Please also have a look at our
 
 ### Fixed
 
+- Parse `@font-face` `src` property as comma-delimited list (#790)
 - Fix type errors in PHP strict mode (#664)
 - Fix undefined local variable in `CalcFunction::parse()` (#593)
 - Fix PHP notice caused by parsing invalid color values having less than 6

src/Rule/Rule.php

@@ -114,16 +114,26 @@ public static function parse(ParserState $oParserState): Rule
     }
 
     /**
+     * Returns a list of delimiters (or separators).
+     * The first item is the innermost separator (or, put another way, the highest-precedence operator).
+     * The sequence continues to the outermost separator (or lowest-precedence operator).
+     *
      * @param string $sRule
      *
-     * @return array<int, string>
+     * @return list<non-empty-string>
      */
     private static function listDelimiterForRule($sRule): array
     {
         if (\preg_match('/^font($|-)/', $sRule)) {
             return [',', '/', ' '];
         }
-        return [',', ' ', '/'];
+
+        switch ($sRule) {
+            case 'src':
+                return [' ', ','];
+            default:
+                return [',', ' ', '/'];
+        }
     }
 
     /**

tests/Unit/.gitkeep

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Sabberworm\CSS\Tests\Unit\Rule;
+
+use PHPUnit\Framework\TestCase;
+use Sabberworm\CSS\Parsing\ParserState;
+use Sabberworm\CSS\Settings;
+use Sabberworm\CSS\Rule\Rule;
+use Sabberworm\CSS\Value\RuleValueList;
+use Sabberworm\CSS\Value\ValueList;
+
+/**
+ * @covers \Sabberworm\CSS\Rule\Rule
+ */
+final class RuleTest extends TestCase
+{
+    /**
+     * @return array<string, array{0: string, 1: list<class-string>}>
+     */
+    public static function provideRulesAndExpectedParsedValueListTypes(): array
+    {
+        return [
+            'src (e.g. in @font-face)' => [
+                "
+                    src: url('../fonts/open-sans-italic-300.woff2') format('woff2'),
+                         url('../fonts/open-sans-italic-300.ttf') format('truetype');
+                ",
+                [RuleValueList::class, RuleValueList::class],
+            ],
+        ];
+    }
+
+    /**
+     * @test
+     *
+     * @param list<class-string> $expectedTypeClassnames
+     *
+     * @dataProvider provideRulesAndExpectedParsedValueListTypes
+     */
+    public function parsesValuesIntoExpectedTypeList(string $rule, array $expectedTypeClassnames): void
+    {
+        $subject = Rule::parse(new ParserState($rule, Settings::create()));
+
+        $value = $subject->getValue();
+        self::assertInstanceOf(ValueList::class, $value);
+
+        $actualClassnames = \array_map(
+            /**
+             * @param Value|string $component
+             */
+            static function ($component): string {
+                return \is_string($component) ? 'string' : \get_class($component);
+            },
+            $value->getListComponents()
+        );
+
+        self::assertSame($expectedTypeClassnames, $actualClassnames);
+    }
+}