handle corner case with bad props in simple component

Morglod · Jul 12, 2024 · 67cfefe · 67cfefe
1 parent 4dd2557
commit 67cfefe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/build_examples/demo.js b/build_examples/demo.js
@@ -170,6 +170,8 @@ function SimpleVirtualListV(props) {
         itemHeight: props.itemHeight,
         renderItem: (itemIndex, topOffset) => {
             const item = props.items[itemIndex];
+            if (!item)
+                return null;
             return ((0, jsx_runtime_1.jsx)("div", { style: { position: 'absolute', top: `${topOffset}px` }, children: props.renderItem(item, itemIndex, topOffset) }, props.itemKey(item, itemIndex)));
         }
     }, [props.items, props.itemHeight]);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-virtual-overflow",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "virtual scroll without headache",
   "main": "lib/index.cjs.js",
   "module": "lib/index.esm.js",

diff --git a/src/simple.tsx b/src/simple.tsx
@@ -19,6 +19,7 @@ export function SimpleVirtualListV<ItemT>(props: SimpleVirtualListVProps<ItemT>)
         itemHeight: props.itemHeight,
         renderItem: (itemIndex: number, topOffset: number) => {
             const item = props.items[itemIndex];
+            if (!item) return null;
             return (
                 <div style={{ position: 'absolute', top: `${topOffset}px` }} key={props.itemKey(item, itemIndex)}>
                     {props.renderItem(item, itemIndex, topOffset)}