Hide attachment icon for custom form editor popup and not saved record

On not saved records in form editor popup, it shouldn't show the
attachment icon. Same for some custom form editor popups like user
preferences.

Fixes #1393

Author: mma-axelor

axelor-front/src/hooks/use-relation/use-editor.tsx

@@ -4,7 +4,7 @@ import isEqual from "lodash/isEqual";
 import uniqueId from "lodash/uniqueId";
 import { useCallback, useEffect, useRef } from "react";
 
-import { Box, Button, CommandBar, CommandItemProps } from "@axelor/ui";
+import { Box, Button, CommandBar } from "@axelor/ui";
 
 import { dialogs } from "@/components/dialogs";
 import { openTab_internal as openTab } from "@/hooks/use-tabs";
@@ -30,6 +30,7 @@ export type EditorOptions = {
   view?: FormView;
   viewName?: string;
   context?: DataContext;
+  canAttach?: boolean;
   canSave?: boolean;
   params?: ActionView["params"];
   header?: PopupProps["header"];
@@ -101,6 +102,7 @@ export function useEditor() {
       context,
       readonly,
       maximize,
+      canAttach = true,
       canSave = true,
       params,
       header,
@@ -141,6 +143,7 @@ export function useEditor() {
       footer: ({ close }) => (
         <Footer
           footer={footer}
+          canAttach={canAttach && (record?.id ?? 0) > 0}
           hasOk={canSave}
           params={tabParams}
           onClose={close}
@@ -154,13 +157,15 @@ export function useEditor() {
 }
 
 function Footer({
+  canAttach = true,
   hasOk = true,
   footer: FooterComp,
   params,
   onClose,
   onSave,
   onSelect,
 }: {
+  canAttach?: boolean;
   hasOk?: boolean;
   footer?: EditorOptions["footer"];
   onClose: (result: boolean) => void;
@@ -251,11 +256,11 @@ function Footer({
 
   const { attachmentItem } = handler;
 
-  const commandItems = [attachmentItem].filter(Boolean) as CommandItemProps[];
-
   return (
     <>
-      {commandItems && <CommandBar items={commandItems} iconOnly />}
+      {canAttach && attachmentItem && (
+        <CommandBar items={[attachmentItem]} iconOnly />
+      )}
       <Box d="flex" flex={1} justifyContent="flex-end" g={2}>
         {FooterComp && <FooterComp close={onClose} />}
         <Box d="flex" g={2}>

axelor-front/src/layout/nav-header/nav-header.tsx

@@ -343,6 +343,7 @@ function FarItems() {
       model: "com.axelor.auth.db.User",
       title: i18n.get("Preferences"),
       viewName: "user-preferences-form",
+      canAttach: false,
       record: {
         id: session.info?.user?.id,
       },

axelor-front/src/views/dms/dms.tsx

@@ -410,6 +410,7 @@ export function Dms(props: ViewProps<GridView>) {
         model: view.model!,
         viewName: "dms-file-permission-form",
         record: doc,
+        canAttach: false,
         readonly: false,
         onSelect: () => {},
       });

axelor-front/src/views/form/widgets/mail-messages/message/message.tsx

@@ -84,6 +84,7 @@ export function MessageUser({
           record: { id },
           readonly: true,
           canSave: false,
+          canAttach: false,
         });
       } else if (isDevelopment() && !view) {
         console.log(`${name} view doesn't exist`);

changelogs/unreleased/fix-hide-attachment-in-popup-form-editor.yml

@@ -0,0 +1,6 @@
+---
+title: Hide attachment icon for custom form editor popup and not saved record
+type: fix
+description: |
+  On not saved records in form editor popup, it shouldn't show the attachment icon.
+  Same for some custom form editor popups like user preferences.