Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis tests for python 2.6 are failing #1294

Closed
RStatkevych opened this issue May 12, 2016 · 7 comments
Closed

Travis tests for python 2.6 are failing #1294

RStatkevych opened this issue May 12, 2016 · 7 comments
Labels

Comments

@RStatkevych
Copy link

Travis show tests failing on python2.6 when I was trying to submit my pull request [#1282] . First I thought that this is my fault, but I see that that few recent builds have the same fails as mine (for example https://travis-ci.org/MongoEngine/mongoengine/jobs/128043817 and mine is https://travis-ci.org/MongoEngine/mongoengine/jobs/129869183). What the problem can it be? Is this travis problem or mongoengine?

P.S: I noticed that it's not reported or asked yet, so let it be here

@lafrech lafrech added the Bug label May 24, 2016
@wojcikstefan
Copy link
Member

Yup, noticed that, too. Few thoughts about this:

  • It appears that the error comes from the rednose package. I looked at https://github.com/JBKahn/rednose to see if it supports Py v2.6 , but don't see anything.
  • This is an example of adding a dependency that's not really necessary - it comes at a price, and IMHO the price is higher than the value it provides (some nice colors in the nosetests' output).
  • We we even want to keep Py2.6 support? Personally I'd push for dropping it sooner rather than later.

@lafrech @thedrow what do you think?

@lafrech
Copy link
Member

lafrech commented Jul 11, 2016

I've been dealing with code tested with pytest recently and I can't tell the difference. I don't know what it would take to make the transition. In fact, in my recent projects, I've been using nosetests... because I copid MongoEngine... No objection to this change if everyone feels like porting the tests. Should we file a dedicated issue ?

Regarding Python 2.6, I don't mind. The least old versions we support, the easiest. I guess the rationale is that some Linux distros like Red Hat will still ship 2.6 for about 5 years. But users can install 2.7 and I have no idea who actually uses 2.6 and who would be totally blocked (can't move to 2.7 for any platform or other lib issue). It's quite possible that users already moved to 2.7 for another dependency.

Considering current effort put into MongoEngine and bugs piling up almost daily, 2.6 support might be a luxury so it could be justified to drop it. If anyone really needs it and is willing to work on it, it's never too late to move back. Meanwhile, we may remove it from the tests and let it go.

As to the root cause of the rednose issue, I don't know if it breaks while processing working code, or while dealing with an error in MongoEngine.

@wojcikstefan
Copy link
Member

So we have +3 on dropping python 2.6 support (which, at least for now, would only include dropping it from the tox config) - is there anybody else that should give a thumbs up before this decision is made?

As to the root cause of the rednose issue, I don't know if it breaks while processing working code, or while dealing with an error in MongoEngine.

Yea, I don't know as well, but it's bad either way... It either covers up the actual error or it makes a successful test fail. Anyway, it doesn't seem to be an issue in Py 2.7+.

@lafrech
Copy link
Member

lafrech commented Jul 13, 2016

Let's ping @MongoEngine/mongoengine team, just in case...

@lafrech
Copy link
Member

lafrech commented Oct 19, 2016

Closed by #1391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@wojcikstefan @lafrech @RStatkevych and others