Skip to content

Chunk$EnumCreateEntityType -> Chunk$RequestType #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
ChloeDawn opened this issue Sep 3, 2018 · 1 comment
Closed
1 task

Chunk$EnumCreateEntityType -> Chunk$RequestType #722

ChloeDawn opened this issue Sep 3, 2018 · 1 comment
Labels
class name

Comments

@ChloeDawn
Copy link

ChloeDawn commented Sep 3, 2018 •
edited
Loading

  • net/minecraft/world/chunk/Chunk$EnumCreateEntityType -> Chunk$RequestType

It makes no sense for an enum class to imply creation semantics when a constant of CHECK exists. The enum is used as more of a request type, to determine how a requested object is processed (currently only implemented for TileEntity lookups in Chunk).

  • RequestType.IMMEDIATE would imply the requested object will be immediately processed.
  • RequestType.QUEUED would imply the requested object will be queued for processing.
  • RequestType.CHECK would imply you're checking for the presence of a requested object.

See also: #717
@LexManos
Copy link
Member

It has been open for over a year and no comments. Closing due to nobody caring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class name
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LexManos @kashike @ChloeDawn