Disabling vanilla ore generation doesn't work.

[Trinsdar]

This is my orespawn.json: https://paste.dimdev.org/ciwoluzafo.json
I have B:"Replace Vanilla Oregen"=true in the orespawn config.
OreSpawn-1.12-3.3.0.136

Edit: I should note that I have Geolosys installed in case that might be conflicting.

[dshadowwolf]

We have had some other reports of Geolosys getting in the way - if it is that, then CoFHWorld would also be failing here, as we use the same method of stopping generation. That is, we cancel the event for all vanilla material types.

Looks like another test environment needs to be setup.

[Trinsdar]

I'll test in just geolosys + orespawn, cofh + geolosys, and just orespawn

[dshadowwolf]

Hrm... this is strange, then. As I noted on the MMD Discord, the code we use for managing the "replace vanilla ore generation" is close to identical to what is in CoFHWorld - there might be an issue with the conditional that controls the event handler registration, though, hrm...

[Trinsdar]

ok this is wierd. just by itself and geolosys it works but it doesn't work in my pack. I have to do more testing though.

[Trinsdar]

so there's no vanilla ore gen even without the vanilla override set to true which means that geolosys is disabling vanilla ore gen.

[Trinsdar]

means I can't tell if it's geolosys or orespawn that's having the problem.

[Trinsdar]

upon removing geolosys vanilla ore gen worked so therefore geolosys stopped vanilla ore gen.

[Trinsdar]

and your vanilla removing works by itself so no problems there.

[Trinsdar]

I think I can safely say that another mod is intefering with geolosys in my pack.

[Trinsdar]

I don't think it's orespawn

[Trinsdar]

mabye it's minerology?
it did create an errored file underneath the config file

[jriwanek]

Can you pastebin it please.

[Trinsdar]

I can upload the file. I can't pastebin it as its a .errored file and I don't know how to open it.

[Trinsdar]

https://www.mediafire.com/file/92x5h5smfx8c695/mineralogy.cfg_20180715_110907.errored

[jriwanek]

It's a text document with a funny extention, opens just fine in notepad++.
Not 100% sure, but I'd assume something in it is invalid.

[Trinsdar]

https://paste.dimdev.org/iwaserofow.bash

[dshadowwolf]

I'm not positive - I think the bit starting at line 133 might be the culprit:

    # Adds blocks to rock layers (format is mod:block as a semicolon (;) delimited list) [default: ]
    S:sedimentary_whitelist=
    earthworks:block_slate; 
    earthworks:block_slate_green; 
    earthworks:block_slate_purple; 
    earthworks:block_chalk

I think this might need to be:

S:sedimentary_whitelist=earthworks:block_slate;earthworks:block_slate_green;earthworks:block_slate_purple;earthworks:block_chalk

Just to satisfy the Forge config parser

[jriwanek]

Give it a go, let us know, really it should be an array instead of a big string. (We should fix that at some point)

[Trinsdar]

looks like minerology isn't causing it as when just it, base metals, base minerals, orespawn, and geolosys are in vanilla ores don't spawn. yet they spawn in my pack. I'm going to upload the mods and configs i have so you can test.

[Trinsdar]

I probobly won't link it till later tommoraw/today(it's 12am) since it's taking a long time to upload.

[Trinsdar]

https://www.amazon.com/clouddrive/share/tamjiLvHuy0Abt5QYOeTZGJ03mCIxxtmSuhWPy9BPiO

[dshadowwolf]

Has this been tested with the fixes that went in on the Maven recently ?

[jriwanek]

Not yet, no.