Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla ore generation can not be disabled #115

Open
Pentasis opened this issue Nov 20, 2019 · 5 comments
Open

Vanilla ore generation can not be disabled #115

Pentasis opened this issue Nov 20, 2019 · 5 comments
Assignees
Labels

Comments

@Pentasis
Copy link

When I use COFH World or Geolosys to override the vanilla ore generation, Mineralogy still generates the vanilla ores beside them. So I end up with ores where I don't want them. (e.g. I want coal only to generate in Swamp biomes, which COFH World will let me do, but Mineralogy still generates coal everywhere else).

@jriwanek jriwanek added the bug label Nov 20, 2019
@SkyBlade1978
Copy link
Collaborator

Hi, I assume you're using Mineralogy 1.12? This version of mineralogy doesn't specifically do anything with coal at all, except for a couple of recipes, however the way mineralogy works is by replacing the world provider which other mods (such as the ones you mentioned) may also be doing which would cause the issue you're seeing. One of the next updates I plan to make to mineralogy should give it the ability to control all the vanilla ore generation as it will team up with OreSpawn.

@Pentasis
Copy link
Author

Yes, I meant 1.12.2.
I'll look for a workaround until the update then; thanks :)

@SkyBlade1978
Copy link
Collaborator

Though I haven't tried it myself so I can't be sure, I would try running mmd orespawn and looking at the settings for that to see if it can disable vanilla coal (in the future mineralogy will be coupled to this mod anyway)

@dshadowwolf
Copy link

For CoFHWorld in 1.12 the disabling of vanilla generation is done via canceling an event (basically) - if Mineralogy isn't paying attention to this event internally, it could lead to it still generating some ores. (I know because I actually looked to see how it did it when writing MMD OreSpawn 3)

I do not know how Geolosys does it, but it might be similar.

@SkyBlade1978
Copy link
Collaborator

I have integrated mineralogy with OS3 (partially), when I complete the OS3 integration all the mineralogy ores will be placed by os3 instead and therefore, this will be resolved

@SkyBlade1978 SkyBlade1978 self-assigned this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants