Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golems not being removed/deleted via datapacks #133

Open
Wackywee opened this issue Apr 16, 2024 · 6 comments
Open

Golems not being removed/deleted via datapacks #133

Wackywee opened this issue Apr 16, 2024 · 6 comments

Comments

@Wackywee
Copy link

Why can I only remove the quark charcoal golem via datapack? I put the other ones I want to remove in the same directory, and all of the following directories and it doesnt work. (Integration_Pack is the name of my datapack)

Integration_Pack\data\golems\golems\golem_stats
Integration_Pack\data\golems\extragolems\golems\golems\golem_stats
Integration_Pack\data\golems\extragolems\golems\golem_stats
Integration_Pack\data\golems\extragolems\golem_stats
Integration_Pack\data\golems\golem_stats
Integration_Pack\data\extragolems\golem_stats
Integration_Pack\data\extragolems\golems\golem_stats
Integration_Pack\data\extragolems\golems\golems\golem_stats

I think the directory in your wiki is incorrect. Here is the composition of each .json:
{
"attributes": {}
}

Thank you for any help.

@skyjay1
Copy link
Member

skyjay1 commented Apr 16, 2024

data/golems/golems is the correct directory for the charcoal golem in your version. For other golems added by quark, you need to use the data/quark/golems directory
https://github.com/MinecraftModDevelopmentMods/Extra-Golems/tree/master-1.19.3/src/main/resources/golems_addon_quark/data/quark/golems

@skyjay1 skyjay1 closed this as completed Apr 16, 2024
@Wackywee
Copy link
Author

data/golems/golems is the correct directory for the charcoal golem in your version. For other golems added by quark, you need to use the data/quark/golems directory https://github.com/MinecraftModDevelopmentMods/Extra-Golems/tree/master-1.19.3/src/main/resources/golems_addon_quark/data/quark/golems

Sorry for the confusion, I was referring to the golems added by default, not quark. Such as the wool, deepslate, andesite, etc.

@skyjay1 skyjay1 reopened this Apr 16, 2024
@skyjay1
Copy link
Member

skyjay1 commented Apr 16, 2024

Integration_Pack\data\golems\golems\golem_stats

This is the correct path for 1.16.5 through 1.19.3. If you are using 1.20.1, the wiki is not updated yet.

Please verify the data pack is loaded in-game with the /datapack list command

Also when you say it “doesn’t work” do you mean that the golem can still be built? Or do you mean it shows up in the guide book? The latter can be resolved by adding ”hidden”: true to the JSON

@Wackywee
Copy link
Author

Wackywee commented Apr 16, 2024

I'm using version 1.19.2, and my datapack is enabled. I have all features from it except the golems being disabled, as shown by this in the log that was printed following the /datapack list command
[file/Integration_Pack (world)]

By doesn't work I mean the golems can still be built, which leads me to believe I would also be unable to change their attributes

Of additional note, your mentioned file path does work with my attempts to remove the charcoal golem.

@Wackywee
Copy link
Author

Is this going to be fixed?

@KiriCattus
Copy link

I'm unsure if 1.19.* is currently receiving support but sky is very busy with real life duties right now, as soon as either sky or someone else has a moment to poke this issue they will :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants