Star steel buff only works when at full armor durability

I'm not sure if this is a bug or an intended feature but the star steel armor buff of the speed and jump buff, only works when at full armor durability. If it is intended seems harsh to me given that, this means even 1 damage makes the effect stop working.

This is in the 1.12 update using what is (at the time of posting) the latest release.

Not to sound anal but you should try, if possible, to post the specific versions of each mod used :)
Also indicate the forge version and if applicable, what mod-pack and version this happens in. That's pretty much standard practice and will save everyone a lot of time 99% of the time.
As for the armor effect, quite likely a bug on our side, I don't think even our team has that much of a sadist xD

it is most likely this code:

BaseMetals/src/main/java/com/mcmoddev/basemetals/properties/BMEPropertyBase.java

Lines 17 to 22 in 3947842

    
           private static boolean playerHasArmorItem(ItemStack piece, EntityPlayer player) { 
        
           	return  ((player.getItemStackFromSlot(EntityEquipmentSlot.HEAD) == piece) 
        
           	|| (player.getItemStackFromSlot(EntityEquipmentSlot.CHEST) == piece) 
        
           	|| (player.getItemStackFromSlot(EntityEquipmentSlot.LEGS) == piece) 
        
           	|| (player.getItemStackFromSlot(EntityEquipmentSlot.FEET) == piece)); 
        
           }

that is failing... because its comparing itemstacks and not doing it in a manner that is blind to item stack damage. A fix will be in -rc3... which will come when RL stops interfering :)

Cold Iron act like this too(and I suppose every armor)
Can't wait for RC3 then :D

Can confirm for adamantite as well. Full durability gets the effect, any damage and it poofs away!

Any ETA on this? will it be fixed in 1.12.2? thanks :)

will be. Sorry - my paycheck keeps getting in the way of my hobbies, sadly DRH

…

On Wed, Jan 15, 2020 at 2:28 AM Raymond Tremblay ***@***.***> wrote: Any ETA on this? will it be fixed in 1.12.2? thanks :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#450?email_source=notifications&email_token=AACL7IQCRRPMOAR5ZJT2ESTQ523JLA5CNFSM4H3D6SEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7KTSY#issuecomment-574532043>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACL7IWZMJNRBC7W2MYV5ITQ523JLANCNFSM4H3D6SEA> .

As hard as it is to say... Meeting requirements and expectations of paying clients is getting in the way of me working on my hobbies. Sorry.

I feel you XD, just wanted to make sure everything was OK and not abandoned lol
RL always come first :)

I just saw, right now (Basemetals-1.12-2.5.0-Rc2.332) if 3 pieces of armor are damaged, but 1 at full durability, the full armor effect is active

Hrm... I don't recall pushing the fix for this, perhaps Jas did it...

Finish Base Metals 2.6.0 for Minecraft 1.12.2

Fixed in Base Metals 2.6.0.112021.

Armor effects now identify the equipped items without comparing their damage values. Starsteel's Speed and Jump Boost therefore keep working when the armor loses durability. Losing those bonuses after taking damage was a bug, not an intended penalty.

Closing this as resolved. Thanks for reporting it and helping narrow down the cause.

Navigation Menu

Repository navigation

Star steel buff only works when at full armor durability #450

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	private static boolean playerHasArmorItem(ItemStack piece, EntityPlayer player) {
	return ((player.getItemStackFromSlot(EntityEquipmentSlot.HEAD) == piece)
	\|\| (player.getItemStackFromSlot(EntityEquipmentSlot.CHEST) == piece)
	\|\| (player.getItemStackFromSlot(EntityEquipmentSlot.LEGS) == piece)
	\|\| (player.getItemStackFromSlot(EntityEquipmentSlot.FEET) == piece));
	}

Star steel buff only works when at full armor durability #450

Description

Activity

YaibaToKen commented on Jun 25, 2019

dshadowwolf commented on Jun 25, 2019

drakray commented on Jul 30, 2019

Akitori commented on Dec 13, 2019

drakray commented on Jan 15, 2020

dshadowwolf commented on Jan 15, 2020

dshadowwolf commented on Jan 15, 2020

drakray commented on Jan 15, 2020

drakray commented on May 10, 2020

dshadowwolf commented on May 10, 2020

SkyBlade1978 commented on Oct 1, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions